Refactor/check provider by model #585

zerob13 · 2025-07-07T14:41:26Z

支持通过对特定模型发起一个请求来验证key是否准确

修复问题 #579

Summary by CodeRabbit

New Features
- Introduced a global "Model Check" dialog for testing the connectivity and availability of specific models from providers.
- Added UI components and state management for opening and closing the model check dialog across settings and welcome views.
- Users can now select and test individual models, with success or error feedback displayed in the dialog.
- Enhanced model validation with detailed response checks and error handling for improved reliability.
Localization
- Added translations for the new model check dialog in English, Persian, French, Japanese, Korean, Russian, Simplified Chinese, Traditional Chinese, and Chinese (Hong Kong).
Refactor
- Replaced previous API key validation flows with the new model check dialog in relevant settings and onboarding screens.

coderabbitai · 2025-07-07T14:41:32Z

Walkthrough

A new "Model Check" feature was introduced, enabling users to test the connectivity and usability of specific models for AI providers. This involved updating backend and frontend logic, adding a dialog component for model checking, integrating a new Pinia store for dialog state, modifying validation flows, and extending localization files with relevant UI strings in multiple languages.

Changes

File(s)	Change Summary
src/main/presenter/llmProviderPresenter/index.ts src/shared/presenter.d.ts	Updated `check` method to accept optional `modelId`, perform detailed model-level validation, and handle errors. Updated interface accordingly.
src/renderer/src/stores/settings.ts	Modified `checkProvider` to accept an optional `modelId` and pass it to the presenter.
src/renderer/src/stores/modelCheck.ts	Added new Pinia store to manage model check dialog state and current provider ID.
src/renderer/src/components/settings/ModelCheckDialog.vue	Added new dialog component for model checking with async validation and UI states.
src/renderer/src/App.vue	Integrated `ModelCheckDialog` globally and connected it to the store for visibility control.
src/renderer/src/components/settings/ModelProviderSettingsDetail.vue src/renderer/src/components/settings/OllamaProviderSettingsDetail.vue src/renderer/src/components/settings/ProviderApiConfig.vue	Replaced API key validation handlers with logic to open the model check dialog via the store.
src/renderer/src/views/WelcomeView.vue	Replaced inline API key validation with model check dialog; updated UI and methods accordingly.
src/renderer/src/i18n/en-US/settings.json src/renderer/src/i18n/fa-IR/settings.json src/renderer/src/i18n/fr-FR/settings.json src/renderer/src/i18n/ja-JP/settings.json src/renderer/src/i18n/ko-KR/settings.json src/renderer/src/i18n/ru-RU/settings.json src/renderer/src/i18n/zh-CN/settings.json src/renderer/src/i18n/zh-HK/settings.json src/renderer/src/i18n/zh-TW/settings.json	Added new localization strings for the model check dialog and related UI in multiple languages.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI (Dialog)
    participant ModelCheckStore
    participant SettingsStore
    participant LLMProviderPresenter

    User->>UI (Dialog): Open Model Check Dialog (select provider/model)
    UI (Dialog)->>ModelCheckStore: openDialog(providerId)
    ModelCheckStore->>UI (Dialog): Set isDialogOpen, currentProviderId

    User->>UI (Dialog): Select model and click "Test"
    UI (Dialog)->>SettingsStore: checkProvider(providerId, modelId)
    SettingsStore->>LLMProviderPresenter: check(providerId, modelId)
    LLMProviderPresenter-->>SettingsStore: { isOk, errorMsg }
    SettingsStore-->>UI (Dialog): Result
    UI (Dialog)-->>User: Show success or error message

Poem

A dialog hops up, a test to begin,
Choose your model—let the checks spin!
With languages many, and spinners that twirl,
Success or error, the verdict unfurls.
Now rabbits can rest, with models in check—
Our code’s more robust, what the heck!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 707bb9b and a631087.

📒 Files selected for processing (1)

src/main/presenter/llmProviderPresenter/index.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/main/presenter/llmProviderPresenter/index.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build-check (x64)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

zerob13 · 2025-07-07T14:43:00Z

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/main/presenter/llmProviderPresenter/index.ts (1)
1004-1039: Excellent enhancement: Model-level validation with comprehensive testing.

The enhanced check method represents a significant improvement over simple provider validation:

Strengths:

Performs actual completion requests to validate model functionality

Comprehensive error handling with proper logging following coding guidelines

Structured return type with clear success/error indication

Validates multiple response types (content, reasoning_content)

Minor Suggestion:
Consider adding a timeout for the completion test to prevent indefinite hanging:
const testMessage = [{ role: 'user' as const, content: 'hi' }]
-const response = await provider.completions(testMessage, modelId, 0.1, 10)
+const response = await Promise.race([
+  provider.completions(testMessage, modelId, 0.1, 10),
+  new Promise((_, reject) => setTimeout(() => reject(new Error('Model test timeout')), 30000))
+])

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c757766 and 707bb9b.

📒 Files selected for processing (19)

src/main/presenter/llmProviderPresenter/index.ts (1 hunks)
src/renderer/src/App.vue (3 hunks)
src/renderer/src/components/settings/ModelCheckDialog.vue (1 hunks)
src/renderer/src/components/settings/ModelProviderSettingsDetail.vue (4 hunks)
src/renderer/src/components/settings/OllamaProviderSettingsDetail.vue (4 hunks)
src/renderer/src/components/settings/ProviderApiConfig.vue (4 hunks)
src/renderer/src/i18n/en-US/settings.json (1 hunks)
src/renderer/src/i18n/fa-IR/settings.json (1 hunks)
src/renderer/src/i18n/fr-FR/settings.json (1 hunks)
src/renderer/src/i18n/ja-JP/settings.json (1 hunks)
src/renderer/src/i18n/ko-KR/settings.json (1 hunks)
src/renderer/src/i18n/ru-RU/settings.json (1 hunks)
src/renderer/src/i18n/zh-CN/settings.json (1 hunks)
src/renderer/src/i18n/zh-HK/settings.json (1 hunks)
src/renderer/src/i18n/zh-TW/settings.json (1 hunks)
src/renderer/src/stores/modelCheck.ts (1 hunks)
src/renderer/src/stores/settings.ts (1 hunks)
src/renderer/src/views/WelcomeView.vue (5 hunks)
src/shared/presenter.d.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (12)

`src/renderer/src/**/*`: All user-facing strings in the renderer must use i18n k...

src/renderer/src/**/*: All user-facing strings in the renderer must use i18n keys (do not hardcode user-visible text in code; use vue-i18n translation keys instead)
Do not hardcode user-facing text in code; always use the translation system (vue-i18n) for all user-visible strings

📄 Source: CodeRabbit Inference Engine (.cursor/rules/i18n.mdc)