Skip to content

fix: toggle model config refresh #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 1 commit into from
Nov 10, 2025
Merged

fix: toggle model config refresh #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 81 additions & 22 deletions src/renderer/src/stores/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import { defineStore } from 'pinia'
import { ref, onMounted, toRaw, computed } from 'vue'
import { type LLM_PROVIDER, type MODEL_META, type RENDERER_MODEL_META } from '@shared/presenter'
import {
type LLM_PROVIDER,
type MODEL_META,
type RENDERER_MODEL_META,
type ModelConfig
} from '@shared/presenter'
import type { ProviderChange, ProviderBatchUpdate } from '@shared/provider-operations'
import { ModelType } from '@shared/model'
import { usePresenter } from '@/composables/usePresenter'
Expand Down Expand Up @@ -387,6 +392,43 @@ export const useSettingsStore = defineStore('settings', () => {
}
}

const applyUserDefinedModelConfig = async (
model: RENDERER_MODEL_META,
providerId: string
): Promise<RENDERER_MODEL_META> => {
const normalizedModel: RENDERER_MODEL_META = {
...model,
vision: model.vision ?? false,
functionCall: model.functionCall ?? false,
reasoning: model.reasoning ?? false,
enableSearch: model.enableSearch ?? false,
type: model.type ?? ModelType.Chat
}

try {
const config: ModelConfig | null = await configP.getModelConfig(model.id, providerId)
if (config?.isUserDefined) {
const resolvedMaxTokens =
config.maxTokens ?? config.maxCompletionTokens ?? normalizedModel.maxTokens

return {
...normalizedModel,
contextLength: config.contextLength ?? normalizedModel.contextLength,
maxTokens: resolvedMaxTokens,
vision: config.vision ?? normalizedModel.vision ?? false,
functionCall: config.functionCall ?? normalizedModel.functionCall ?? false,
reasoning: config.reasoning ?? normalizedModel.reasoning ?? false,
enableSearch: config.enableSearch ?? normalizedModel.enableSearch ?? false,
type: config.type ?? normalizedModel.type ?? ModelType.Chat
}
}
} catch (error) {
console.error(`读取模型配置失败: ${providerId}/${model.id}`, error)
}

return normalizedModel
}

// 刷新单个提供商的自定义模型
const refreshCustomModels = async (providerId: string): Promise<void> => {
try {
Expand All @@ -401,15 +443,18 @@ export const useSettingsStore = defineStore('settings', () => {
const modelStatusMap =
modelIds.length > 0 ? await configP.getBatchModelStatus(providerId, modelIds) : {}

const customModelsWithStatus = safeCustomModelsList.map((model) => {
return {
...model,
enabled: modelStatusMap[model.id] ?? true,
providerId,
isCustom: true,
type: model.type || ModelType.Chat
} as RENDERER_MODEL_META
})
const customModelsWithStatus = await Promise.all(
safeCustomModelsList.map(async (model) => {
const baseModel: RENDERER_MODEL_META = {
...model,
enabled: modelStatusMap[model.id] ?? true,
providerId,
isCustom: true,
type: model.type || ModelType.Chat
}
return await applyUserDefinedModelConfig(baseModel, providerId)
})
)

// 更新自定义模型列表
const customIndex = customModels.value.findIndex((item) => item.providerId === providerId)
Expand Down Expand Up @@ -549,14 +594,22 @@ export const useSettingsStore = defineStore('settings', () => {
const modelStatusMap =
modelIds.length > 0 ? await configP.getBatchModelStatus(providerId, modelIds) : {}

const modelsWithStatus = models.map((model) => {
return {
...model,
enabled: modelStatusMap[model.id] ?? true,
providerId,
isCustom: model.isCustom || false
}
})
const modelsWithStatus = await Promise.all(
models.map(async (model) => {
const baseModel: RENDERER_MODEL_META = {
...model,
enabled: modelStatusMap[model.id] ?? true,
providerId,
isCustom: model.isCustom || false,
vision: model.vision ?? false,
functionCall: model.functionCall ?? false,
reasoning: model.reasoning ?? false,
enableSearch: model.enableSearch ?? false,
type: model.type || ModelType.Chat
}
return await applyUserDefinedModelConfig(baseModel, providerId)
})
)

// 更新全局模型列表中的标准模型
const allProviderIndex = allProviderModels.value.findIndex(
Expand Down Expand Up @@ -1910,20 +1963,26 @@ export const useSettingsStore = defineStore('settings', () => {
return await configP.getModelDefaultConfig(modelId, providerId)
}

const scheduleProviderRefresh = (providerId: string) => {
refreshProviderModels(providerId).catch((error) => {
console.error(`后台刷新模型失败: ${providerId}`, error)
})
}
Comment on lines +1966 to +1970
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix Chinese error message.

Line 1968: The error message "后台刷新模型失败" is in Chinese. As per coding guidelines, all logs and comments must use English.

As per coding guidelines.

Apply this diff:

-      console.error(`后台刷新模型失败: ${providerId}`, error)
+      console.error(`Background model refresh failed: ${providerId}`, error)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const scheduleProviderRefresh = (providerId: string) => {
refreshProviderModels(providerId).catch((error) => {
console.error(`后台刷新模型失败: ${providerId}`, error)
})
}
const scheduleProviderRefresh = (providerId: string) => {
refreshProviderModels(providerId).catch((error) => {
console.error(`Background model refresh failed: ${providerId}`, error)
})
}
🤖 Prompt for AI Agents 
In src/renderer/src/stores/settings.ts around lines 1966 to 1970, the
console.error message uses Chinese text ("后台刷新模型失败"); replace it with an English
message such as "Failed to refresh provider models in background" (or similar),
preserving inclusion of providerId and the error object in the log call so the
output remains: console.error("Failed to refresh provider models in
background:", providerId, error).


const setModelConfig = async (
modelId: string,
providerId: string,
config: any
): Promise<void> => {
await configP.setModelConfig(modelId, providerId, config)
// 配置变更后刷新相关模型数据
await refreshProviderModels(providerId)
// 配置写入成功后触发后台刷新，避免阻塞 UI
scheduleProviderRefresh(providerId)
}

const resetModelConfig = async (modelId: string, providerId: string): Promise<void> => {
await configP.resetModelConfig(modelId, providerId)
// 配置重置后刷新相关模型数据
await refreshProviderModels(providerId)
// 配置重置成功后触发后台刷新
scheduleProviderRefresh(providerId)
}

return {
Expand Down