Skip to content

fix: allow settings window links to open externally #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zerob13 merged 2 commits into from
Oct 19, 2025
Merged

fix: allow settings window links to open externally #1029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
306dfab
fix(settings): allow target blank links
zerob13 Oct 19, 2025
bb3163c
fix: harden settings window link handling
zerob13 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/main/presenter/windowPresenter/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1289,6 +1289,25 @@ export class WindowPresenter implements IWindowPresenter {
this.settingsWindow = settingsWindow
const windowId = settingsWindow.id

// Ensure links with target="_blank" open in the user's default browser
settingsWindow.webContents.setWindowOpenHandler(({ url }) => {
try {
// Validate URL protocol - only allow http/https
const parsedUrl = new URL(url)
if (parsedUrl.protocol === 'http:' || parsedUrl.protocol === 'https:') {
console.log(`Opening external URL from settings window: ${url}`)
shell.openExternal(url).catch((error) => {
console.error(`Failed to open external URL: ${url}`, error)
})
} else {
console.warn(`Blocked attempt to open non-http(s) URL: ${url}`)
}
} catch (error) {
console.error(`Invalid URL format: ${url}`, error)
}
return { action: 'deny' }
})

// Apply content protection settings
const contentProtectionEnabled = this.configPresenter.getContentProtectionEnabled()
this.updateContentProtection(settingsWindow, contentProtectionEnabled)
Expand Down