-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbg 52 integration sq lite with lobby client #19
Open
erikayeah
wants to merge
70
commits into
develop
Choose a base branch
from
CARBG-52-Integration-SQLite-with-LobbyClient
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had created the branch with the old version of develop so it did not have the new changes.
ADD FIXES
UPDATE LOGS, MODIFY SETLOG AND GETLOG
add wipe method
add first commit of list matches
I upload corrections in the test file, and the clearAll method is added so that I can clean up the base at each iteration of the test.
changed name from clearAll to clear in sqlite.test file
* fixing the branch problem and sqlti integration I had created the branch with the old version of develop so it did not have the new changes. * Update sqlite3.ts * chore: added sqlite export * ADD som fixes ADD FIXES * removing unnecessary imports of sqlite.ts * NEW FIXES * FIXES * Update sqlite3.ts * fix log error * Update sqlite3.ts * added a new table called players * Update sqlite3.ts * UPDATE LOGS UPDATE LOGS, MODIFY SETLOG AND GETLOG * add wipe method add wipe method * add list matches add first commit of list matches * Update sqlite3.ts * ADD TEST FILE AND SOME FIXES * Update sqlite3.ts * add fixes * add fixes * delete console.log * some fixes in sqlite.test file I upload corrections in the test file, and the clearAll method is added so that I can clean up the base at each iteration of the test. * changed name from clearAll to clear changed name from clearAll to clear in sqlite.test file * add refacts * add console.log after each * ad fixes * add refacts * added console.logs * Update sqlite3.ts * Update sqlite3.ts * Update master.ts * Update master.ts * ADDED MORE LOGS * Update sqlite3.ts * added more changes * added more logs * added logs * Update sqlite3.ts * Update master.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update cartesify-transport.ts * Update cartesify-transport.ts * Update cartesify-transport.ts * added more changes * added more console logs * delete all console.logs , and added await on master.OnUpdate * addded modifications in set metadata * added comments to the methods * fix: remove unused script * fix: ran prettier on the sqlite3 file and added some comments to the methods --------- Co-authored-by: Lucas Marc <74575331+lucas-marc@users.noreply.github.com> Co-authored-by: Juan Manuel Aragon Paz <98961821+jm-aragonpaz@users.noreply.github.com>
* fixing the branch problem and sqlti integration I had created the branch with the old version of develop so it did not have the new changes. * Update sqlite3.ts * chore: added sqlite export * ADD som fixes ADD FIXES * removing unnecessary imports of sqlite.ts * NEW FIXES * FIXES * Update sqlite3.ts * fix log error * Update sqlite3.ts * added a new table called players * Update sqlite3.ts * UPDATE LOGS UPDATE LOGS, MODIFY SETLOG AND GETLOG * add wipe method add wipe method * add list matches add first commit of list matches * Update sqlite3.ts * ADD TEST FILE AND SOME FIXES * Update sqlite3.ts * add fixes * add fixes * delete console.log * some fixes in sqlite.test file I upload corrections in the test file, and the clearAll method is added so that I can clean up the base at each iteration of the test. * changed name from clearAll to clear changed name from clearAll to clear in sqlite.test file * add refacts * add console.log after each * ad fixes * add refacts * added console.logs * Update sqlite3.ts * Update sqlite3.ts * Update master.ts * Update master.ts * ADDED MORE LOGS * Update sqlite3.ts * added more changes * added more logs * added logs * Update sqlite3.ts * Update master.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update sqlite3.ts * Update cartesify-transport.ts * Update cartesify-transport.ts * Update cartesify-transport.ts * added more changes * added more console logs * delete all console.logs , and added await on master.OnUpdate * addded modifications in set metadata * added comments to the methods * fix: remove unused script * fix: ran prettier on the sqlite3 file and added some comments to the methods --------- Co-authored-by: Lucas Marc <74575331+lucas-marc@users.noreply.github.com> Co-authored-by: Juan Manuel Aragon Paz <98961821+jm-aragonpaz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates SQLite with the LobbyClient and updates the test suite accordingly. It is based on the changes from the CARBG-52-Integration-SQLite-with-LobbyClient branch and includes updates from PR #15 ("Add functionality to list matches and create new games").
Key Updates:
SQLite Integration:
Added SQLite support for managing game states and transactions.
Test Modifications:
Improved input validation and error handling in key methods like createMatch and joinMatch.