-
Notifications
You must be signed in to change notification settings - Fork 0
Update module #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spy86
wants to merge
6
commits into
main
Choose a base branch
from
patch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update module #28
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,59 @@ | ||
| resource "azurerm_container_registry" "main" { | ||
| name = "${var.environment}${var.acr_name}" | ||
| resource_group_name = data.azurerm_resource_group.main.name | ||
| location = data.azurerm_resource_group.main.location | ||
| sku = var.acr_tier | ||
| admin_enabled = var.acr_admin_enabled | ||
| tags = var.default_tags | ||
| } | ||
| name = var.acr_name | ||
| resource_group_name = data.azurerm_resource_group.main.name | ||
| location = var.resource_group_location | ||
| sku = var.acr_tier | ||
| admin_enabled = var.acr_admin_enabled | ||
| public_network_access_enabled = var.public_network_access_enabled | ||
| quarantine_policy_enabled = var.quarantine_policy_enabled | ||
| zone_redundancy_enabled = var.zone_redundancy_enabled | ||
| export_policy_enabled = var.export_policy_enabled | ||
| anonymous_pull_enabled = var.anonymous_pull_enabled | ||
| data_endpoint_enabled = var.data_endpoint_enabled | ||
| network_rule_bypass_option = var.network_rule_bypass_option | ||
| retention_policy_in_days = var.retention_policy != null ? var.retention_policy : null | ||
| trust_policy_enabled = var.trust_policy != null ? var.trust_policy.enabled : false | ||
|
|
||
| dynamic "georeplications" { | ||
| for_each = var.georeplications | ||
| content { | ||
| location = georeplications.value.location | ||
| zone_redundancy_enabled = georeplications.value.zone_redundancy_enabled | ||
| regional_endpoint_enabled = georeplications.value.regional_endpoint_enabled | ||
| tags = merge(var.default_tags, georeplications.value.tags) | ||
| } | ||
| } | ||
|
|
||
| dynamic "network_rule_set" { | ||
| for_each = var.network_rule_set != null ? [var.network_rule_set] : [] | ||
| content { | ||
| default_action = network_rule_set.value.default_action | ||
|
|
||
| dynamic "ip_rule" { | ||
| for_each = network_rule_set.value.ip_rules | ||
| content { | ||
| action = "Allow" | ||
| ip_range = ip_rule.value | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dynamic "identity" { | ||
| for_each = var.identity != null ? [var.identity] : [] | ||
| content { | ||
| type = identity.value.type | ||
| identity_ids = identity.value.identity_ids | ||
| } | ||
| } | ||
|
|
||
| dynamic "encryption" { | ||
| for_each = var.encryption != null ? [var.encryption] : [] | ||
| content { | ||
| key_vault_key_id = encryption.value.key_vault_key_id | ||
| identity_client_id = encryption.value.identity_client_id | ||
| } | ||
| } | ||
|
|
||
| tags = var.default_tags | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,33 @@ | ||
| output "id" { | ||
| description = "The ID of the Container Registry." | ||
| value = azurerm_container_registry.main.id | ||
| sensitive = false | ||
| } | ||
|
|
||
| output "login_server" { | ||
| description = "The URL that can be used to log into the container registry." | ||
| description = "The URL that can be used to log into the Container Registry." | ||
| value = azurerm_container_registry.main.login_server | ||
| sensitive = false | ||
| } | ||
|
|
||
| output "admin_username" { | ||
| description = "The Username associated with the Container Registry Admin account - if the admin account is enabled." | ||
| value = azurerm_container_registry.main.admin_username | ||
| sensitive = true | ||
| value = azurerm_container_registry.main.admin_enabled ? azurerm_container_registry.main.admin_username : null | ||
| } | ||
|
|
||
| output "admin_password" { | ||
| description = "The Password associated with the Container Registry Admin account - if the admin account is enabled." | ||
| value = azurerm_container_registry.main.admin_password | ||
| value = azurerm_container_registry.main.admin_enabled ? azurerm_container_registry.main.admin_password : null | ||
| sensitive = true | ||
| } | ||
|
|
||
| output "data_endpoint_host_names" { | ||
| description = "A set of data endpoint hostnames associated with the Container Registry - if data endpoints are enabled." | ||
| value = azurerm_container_registry.main.data_endpoint_enabled ? azurerm_container_registry.main.data_endpoint_host_names : null | ||
| } | ||
|
|
||
| output "identity" { | ||
| description = "The identity details of the Container Registry, including principal_id and tenant_id, if a managed identity is configured." | ||
| value = azurerm_container_registry.main.identity != null ? { | ||
| principal_id = azurerm_container_registry.main.identity[0].principal_id | ||
| tenant_id = azurerm_container_registry.main.identity[0].tenant_id | ||
| } : null | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| formatter: markdown | ||
| output: | ||
| file: README.md | ||
| mode: inject | ||
| sections: | ||
| show: | ||
| - header | ||
| - requirements | ||
| - providers | ||
| - inputs | ||
| - outputs | ||
| content: | | ||
| # Terraform Azure Container Registry Module | ||
|
|
||
| This Terraform module creates and manages an Azure Container Registry (ACR) with support for all configuration options available in the `azurerm_container_registry` resource for provider version 4.34.0. | ||
|
|
||
| ## Usage | ||
|
|
||
| ```hcl | ||
| module "acr" { | ||
| source = "./terraform-azure-container-registry" | ||
| acr_name = "mycontainerregistry123" | ||
| resource_group_name = "my-resource-group" | ||
| resource_group_location = "West Europe" | ||
| acr_tier = "Premium" | ||
| acr_admin_enabled = true | ||
| public_network_access_enabled = false | ||
| quarantine_policy_enabled = true | ||
| zone_redundancy_enabled = true | ||
| export_policy_enabled = false | ||
| anonymous_pull_enabled = true | ||
| data_endpoint_enabled = true | ||
| network_rule_bypass_option = "AzureServices" | ||
| retention_policy = 7 | ||
| trust_policy = { | ||
| enabled = true | ||
| } | ||
| default_tags = { | ||
| Project = "MyProject" | ||
| Environment = "Production" | ||
| } | ||
| environment = "prod" | ||
| georeplications = [ | ||
| { | ||
| location = "East US" | ||
| zone_redundancy_enabled = true | ||
| regional_endpoint_enabled = true | ||
| tags = { Environment = "prod" } | ||
| } | ||
| ] | ||
| network_rule_set = { | ||
| default_action = "Deny" | ||
| ip_rules = ["203.0.113.0/24"] | ||
| } | ||
| identity = { | ||
| type = "SystemAssigned" | ||
| identity_ids = [] | ||
| } | ||
| encryption = { | ||
| key_vault_key_id = "https://myvault.vault.azure.net/keys/mykey/1234567890abcdef" | ||
| identity_client_id = "<user-assigned-identity-client-id>" | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## Notes | ||
|
|
||
| - The module supports all configuration options available in the `azurerm_container_registry` resource for provider version 4.34.0. | ||
| - Premium SKU is required for features like georeplication, network rules, retention policies, trust policies, and encryption. | ||
| - Ensure the resource group exists before deploying the module. | ||
| - Use the `default_tags` variable to enforce consistent tagging across resources. | ||
|
|
||
| © 2025 Think-Cube |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Premium-only encryption block needs an SKU gate
encryptionis accepted only on Premium registries. Protect the dynamic block so Basic/Standard deployments remain valid.📝 Committable suggestion
🤖 Prompt for AI Agents