Fixed memory leak (#144)

[jgromes]

Fixes #144.

• This PR is compliant with the other contributing guidelines as well (if not, please describe why).
• I have thoroughly tested my contribution.
• Should this code require changes to documentation I will contribute those to https://github.com/ThingPulse/docs.

Methods SunMoonCalc::doCalc() and SunMoonCalc::getMoonDiskOrientationAngles() return pointers to dynamically allocated pointers, which the callers then never deleted, hence the memory leak. Everything is now deleted before reallocating/caller exiting.

[marcelstoer]

Thanks for the fix. Great job.

Is there a convention or common practice where (in the code) to place delete[] or delete? For example here

https://github.com/ThingPulse/esp8266-weather-station/blob/master/src/SunMoonCalc.cpp#L183

you're clearing the allocated memory right before out is reassigned. One could also do that a few lines above after the values from out are last used i.e.

https://github.com/ThingPulse/esp8266-weather-station/blob/master/src/SunMoonCalc.cpp#L173.

[jgromes]

I don't think there's a convention, the memory just has to dealloacted before the function returns or before the memory gets reallocated.

[marcelstoer]

Yep, and one could probably argue that the code is a tad more legible of it's done right before reallocation.

[Leonos]

Wow, I almost missed this. This is great, thank you @marcelstoer and especially @jgromes!!