Return explicit booleans (#98)

wjcarpenter · marcelstoer · commit 850f8fd13e59 · 2019-02-11T10:20:04.000+01:00
I was being prompted to calibrate on every power-up or reset. Returning explicit boolean values
from these methods fixed it for me.
diff --git a/TouchControllerWS.cpp b/TouchControllerWS.cpp
@@ -30,7 +30,7 @@ bool TouchControllerWS::loadCalibration() {
 
   }
   f.close();
-
+  return true;
 }
 
 bool TouchControllerWS::saveCalibration() {
@@ -40,6 +40,7 @@ bool TouchControllerWS::saveCalibration() {
   File f = SPIFFS.open("/calibration.txt", "w");
   if (!f) {
     Serial.println("file creation failed");
+    return false;
   }
   // now write two lines in key/value style with  end-of-line characters
   f.println(dx);
@@ -48,6 +49,7 @@ bool TouchControllerWS::saveCalibration() {
   f.println(ay);
 
   f.close();
+  return true;
 }
 
 void TouchControllerWS::startCalibration(CalibrationCallback *calibrationCallback) {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ bool TouchControllerWS::loadCalibration() {`
`30`	`30`
`31`	`31`	`}`
`32`	`32`	`f.close();`
`33`		`-`
	`33`	`+ return true;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`bool TouchControllerWS::saveCalibration() {`
`@@ -40,6 +40,7 @@ bool TouchControllerWS::saveCalibration() {`
`40`	`40`	`File f = SPIFFS.open("/calibration.txt", "w");`
`41`	`41`	`if (!f) {`
`42`	`42`	`Serial.println("file creation failed");`
	`43`	`+ return false;`
`43`	`44`	`}`
`44`	`45`	`// now write two lines in key/value style with end-of-line characters`
`45`	`46`	`f.println(dx);`
`@@ -48,6 +49,7 @@ bool TouchControllerWS::saveCalibration() {`
`48`	`49`	`f.println(ay);`
`49`	`50`
`50`	`51`	`f.close();`
	`52`	`+ return true;`
`51`	`53`	`}`
`52`	`54`
`53`	`55`	`void TouchControllerWS::startCalibration(CalibrationCallback *calibrationCallback) {`