-
Notifications
You must be signed in to change notification settings - Fork 648
GEOMETRY_64_48 and drawStringf method added #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This PR solve the Issue #73 |
@thorsten-l sorry the PRs weren't processed in due time over the last year. Can I ask you to resolve the conflicts in src/OLEDDisplay.cpp? I had to merge a large PR from @helmut64 first, sorry. |
this->displayWidth = 128; | ||
this->displayHeight = 32; | ||
break; | ||
case GEOMETRY_64_48: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the formatting in this switch
statement (indentation), thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please approve this change request? it has been opened since 2018 and it basically works...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved it a year ago and we would have merged it if all feedback had been addressed or if we had been given permission to edit the file in question ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Marcel,
thanks for replying.
Isn't the only todo open: to fix the indenting of one code block?
Cheers
l.
please reopen this PR and accept the fix |
MiniOLED is perfectly working , but DrawStringf is only documented, does not compile... |
I just compiled and run this sample code successfully, with PlatformIO. |
with this platformio.ini file |
Thank you Thorsten 👍 🥇 |
ESP-SSD1306-DrawStringf-Sample |
Way cool Thorsten! Thanks again for offering such excellent user support. |
I did only to few little changes to get my 64x48 Shield working and i really needed the possibility to do a 'printf' like formatted output. So i implemented a drawStringf method.