Initialize the variable 'feature' from the variable 'features' only when the answer is non-empty #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mptiness of answer is checked, while empty answer has no feature
…mptiness of answer is checked, while empty answer has empty features
ThilinaRajapakse
approved these changes
Mar 2, 2020
|
@all-contributors please add @jacky18008 for code |
|
I've put up a pull request to add @jacky18008! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the empty answer ( which will occur when 'version_2_with_negative' is set to True) has an empty 'features', the previous code will meet a 'list out of index' error for trying indexing on an empty list.
Therefore, initialize the 'feature' by 'features' only when the 'pred.start_index' is greater than 0 can simply fix it. (pred.start_index > 0 means the answer is not empty.)
Moreover, for we do not need the variable 'feature' while the answer is empty, it's OK to do so.