SMTP Auth #28
Open
SMTP Auth #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Jul 23, 2018
|
Thanks for the PR! I'm curious, what client are you using maildump with that requires smtp auth? |
|
Hey, I know it's been a long time, but if you rebase this (and adapt to maildump now being Python 3.6+ only) I'll promise to merge it quickly :) |
…SSWD style file for SMTP authorization
…there is no initial login
|
Hi, |
ThiefMaster
requested changes
Oct 3, 2020
|
|
||
| return self._smtp_auth.check_password(auth_data_splitted[1], auth_data_splitted[2]) | ||
|
|
||
| def smtp_EHLO(self, arg): |
There was a problem hiding this comment.
Do we really need to override all this? A quick google search pointed me to this patch from this python issue where someone tried to get smtp auth support upstream, and they don't override EHLO. However, I don't know how good that implementation is.
There was a problem hiding this comment.
I don't know how in other way push info about AUTH PLAIN to capabilities.
maildump_runner/main.py
Outdated
| @@ -87,11 +91,19 @@ def main(): | |||
| args.htpasswd = os.path.abspath(args.htpasswd) | |||
| print('Htpasswd path is relative, using {0}'.format(args.htpasswd)) | |||
|
|
|||
| if args.smtp_auth and not os.path.isabs(args.smtp_auth): | |||
| args.smtp_auth = os.path.abspath(args.smtp_auth) | |||
| print('SMTP Htpasswd path is relative, using {0}'.format(args.smtp_auth)) | |||
There was a problem hiding this comment.
Suggested change
| print('SMTP Htpasswd path is relative, using {0}'.format(args.smtp_auth)) | |
| print('Htpasswd path for SMTP AUTH is relative, using {0}'.format(args.smtp_auth)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added option to handle smtp authorization. There exists stuff that requires SMTP authorization, and cannot use no auth at all. So I added an option to enable this using options:
--smtp-auth - enable SMTP authorization
--smtp-username, --smtp-password