Update NewRelicLogsSink to implement IBatchedLogEventSink

As is recommended in [the README](https://github.com/serilog/serilog-sinks-periodicbatching/blob/dev/README.md).
ThiagoBarradas · May 25, 2023 · 75e0794 · 75e0794
1 parent 1c20b18
commit 75e0794
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/src/Serilog.Sinks.NewRelic.Logs/Sinks/NewRelicLogs/NewRelicLogsSink.cs b/src/Serilog.Sinks.NewRelic.Logs/Sinks/NewRelicLogs/NewRelicLogsSink.cs
@@ -13,7 +13,7 @@
 
 namespace Serilog.Sinks.NewRelic.Logs
 {
-    internal class NewRelicLogsSink : PeriodicBatchingSink
+    internal class NewRelicLogsSink : IBatchedLogEventSink
     {
         public const int DefaultBatchSizeLimit = 1000;
 
@@ -30,14 +30,11 @@ internal class NewRelicLogsSink : PeriodicBatchingSink
         private IFormatProvider FormatProvider { get; }
 
         public NewRelicLogsSink(
-            string endpointUrl, 
-            string applicationName, 
-            string licenseKey, 
-            string insertKey, 
-            int batchSizeLimit, 
-            TimeSpan period, 
+            string endpointUrl,
+            string applicationName,
+            string licenseKey,
+            string insertKey,
             IFormatProvider formatProvider = null)
-            : base(batchSizeLimit, period)
         {
             this.EndpointUrl = endpointUrl;
             this.ApplicationName = applicationName;
@@ -46,7 +43,7 @@ public NewRelicLogsSink(
             this.FormatProvider = formatProvider;
         }
 
-        protected override async Task EmitBatchAsync(IEnumerable<LogEvent> eventsEnumerable)
+        public async Task EmitBatchAsync(IEnumerable<LogEvent> eventsEnumerable)
         {
             var payload = new NewRelicLogPayload(this.ApplicationName);
             var events = eventsEnumerable.ToList();
@@ -70,6 +67,11 @@ protected override async Task EmitBatchAsync(IEnumerable<LogEvent> eventsEnumera
             await this.SendToNewRelicLogsAsync(body).ConfigureAwait(false);
         }
 
+        public Task OnEmptyBatchAsync()
+        {
+            return Task.CompletedTask;
+        }
+
         private Task SendToNewRelicLogsAsync(string body)
         {
             return Task.Run(() =>