feat(android): replace custom VideoView with media3 PlayerView - #4581
Merged
KrzysztofMoch merged 9 commits intoJul 2, 2025
Conversation
…nd update Podfile.lock for dependency versions
…for audio and text tracks in BasicExample and update UI components for better track labeling
…built-in controls in ExoPlayer integration
…layer control visibility
…ideo scaling, and audio track selection logic
… button visibility in ExoPlayerView
KrzysztofMoch
suggested changes
Jun 30, 2025
KrzysztofMoch
left a comment
Contributor
There was a problem hiding this comment.
It looks good, but there is a lot of "empty" functions that should be removed. Also I see that you removed possibility of setting SurfaceView type - this should be implemented also
…urface view management
PlayerView
KrzysztofMoch
suggested changes
Jul 1, 2025
KrzysztofMoch
left a comment
Contributor
There was a problem hiding this comment.
Please remove those empty functions that have comments
PlayerView manages shutter view automatically
This method is kept for compatibility
And I think we will be ready to merge
KrzysztofMoch
approved these changes
Jul 2, 2025
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
PlayerViewaligns the player with best practices, simplifies future maintenance, and leverages the latest features of the ExoPlayer library.