Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): show the status bar and navigation bar after exiting f… #4112

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix(android): show the status bar and navigation bar after exiting f… #4112

merged 2 commits into from
Sep 3, 2024

Conversation

seyedmostafahasani
Copy link
Collaborator

@seyedmostafahasani seyedmostafahasani commented Aug 22, 2024 •
edited
Loading

…ull-screen mode

Summary

Motivation

Fix #4047, #4107

Changes

Test plan

@seyedmostafahasani seyedmostafahasani mentioned this pull request Aug 22, 2024
Merged
@seyedmostafahasani seyedmostafahasani mentioned this pull request Aug 22, 2024
Closed
@seyedmostafahasani
Copy link
Collaborator Author

@KrzysztofMoch @YangJonghun
If you have enough time please check out this PR.

@freeboub
Copy link
Collaborator

freeboub commented Sep 3, 2024

@KrzysztofMoch Are you OK to merge this PR ?

KrzysztofMoch
KrzysztofMoch approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@freeboub freeboub merged commit 8b8ebe9 into TheWidlarzGroup:master Sep 3, 2024
3 checks passed
@seyedmostafahasani seyedmostafahasani deleted the fix/hide-statusBar-navigationBar branch September 3, 2024 07:28
@seyedmostafahasani seyedmostafahasani mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

@freeboub freeboub freeboub approved these changes

@YangJonghun YangJonghun Awaiting requested review from YangJonghun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Android navigation bar stays hidden after video using fullscreen no longer mounted
3 participants
@seyedmostafahasani @freeboub @KrzysztofMoch