fix(tvos): fix tv os build and sample #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
Comment on lines
+1048
to
+1050
| #if !os(tvOS) | ||
| viewController.updatesNowPlayingInfoCenter = false | ||
| #endif |
There was a problem hiding this comment.
I don't like it... docs say it should work... I will look into this - give me time
There was a problem hiding this comment.
I also don't really like these #if ...
I agree doc say it is supported, but when I go to definition from xcode, It doesn't say it is support on tvOS ...
There was a problem hiding this comment.
So I have double checked that and it's it as you say - strange
Let's merge this
freeboub
commented
May 16, 2024
| @@ -9,7 +9,7 @@ production = ENV["PRODUCTION"] == "1" | |||
|
|
|||
| target 'exampletvOS' do | |||
|
|
|||
| platform :ios, min_ios_version_supported | |||
There was a problem hiding this comment.
@KrzysztofMoch I think we need to document this point also !
Would that fix be better ? #3737 (comment)
There was a problem hiding this comment.
Yes, I am also thinking about adding this info to README (that min ios version is 13) and to upgrade helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix build issue on tvOS and ensure sample is working
Motivation
Fix: #3779
Changes
Conditionnal build patch
Test plan
build and run sample tvOS app