Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add rtsp support #3677

Merged
merged 17 commits into from
Apr 16, 2024
Merged

Feat/add rtsp support #3677

merged 17 commits into from
Apr 16, 2024

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented Apr 15, 2024 •
edited
Loading

Summary

  • add rtsp support

Motivation

will replace: #2824
implement rtsp feature support

⚠️ enabling rtsp support by default will add 149K to every apk as it will embed: media3-exoplayer-rtsp-1.1.1.aar by default. I can make it configurable as this is not a mandatory feature for existing apps

Changes

  • Add exoplayer-rtsp dependancy

Test plan

  • sample url added in sample app

olivier bouillet and others added 16 commits August 21, 2022 15:56
feat(android) : add rtsp support
e34e3d3
Merge branch 'feat/add_new_events_on_tracks_changed' of https://githu…
955919a 
…b.com/react-native-video/react-native-video into feat/add_rtsp_support
fix: update exoplayer-rtsp version
21b12f2
fix: add correct support of rtsp mineType and remove deprecated usage
d27a691
fix: force rtsp stream to use rtsp mine type
397e02e
chore: fix sample build with rtsp support
70b1487
Merge branch 'master' of https://github.com/react-native-video/react-…
6805c55 
…native-video into feat/add_rtsp_support

# Conflicts:
#	Video.js
#	android/build.gradle
#	android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
#	android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java
#	examples/basic/android/gradle.properties
#	examples/basic/yarn.lock
chore: fix bad merge
35b9497
Merge branch 'master' of https://github.com/react-native-video/react-…
255ecd8 
…native-video into feat/add_rtsp_support

# Conflicts:
#	API.md
#	Video.js
#	android/build.gradle
#	android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
#	examples/basic/android/build.gradle
#	examples/basic/package.json
#	examples/basic/src/VideoPlayer.android.tsx
#	examples/basic/yarn.lock
chore: fix merge
5ad376b
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
9b7f60f 
…ideo into feat/add_rtsp_support
@freeboub
fix(ts): onPlaybackRateChangeData was not correctly typed
417bd7a
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
85fb438 
…ideo
@freeboub
Merge branch 'master' of github.com:freeboub/react-native-video into …
9b06faf 
…feat/add_rtsp_support
@freeboub
chore: add sample rtsp stream in demo app
28832f8
@freeboub
chore: revert unexpected change
a34c377
@freeboub freeboub mentioned this pull request Apr 15, 2024
Closed
KrzysztofMoch
KrzysztofMoch approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

I can make it configurable as this is not a mandatory feature for existing apps

I think we can do functionality to disable each of those dependencies to allow fully optimize size of app, WDYT ?

@freeboub
Copy link
Collaborator Author

LGTM 🙌

I can make it configurable as this is not a mandatory feature for existing apps

I think we can do functionality to disable each of those dependencies to allow fully optimize size of app, WDYT ?

Yes, I agree, but maybe instead of being forced to enable each feature, we can allow to disable some feature.
I think it can be done in a second step, I can open a ticket for follow up
For information:

  • media3-exoplayer-1.1.1.aar(mandatory size): 1,2M
    following feature can be enable or disabled
  • media3-exoplayer-dash-1.1.1.aar: 132K
  • media3-exoplayer-hls-1.1.1.aar: 158K
  • media3-exoplayer-ima-1.1.1.aar: 109K (ads insertion, disabled by default)
  • media3-exoplayer-rtsp-1.1.1.aar: 149K
  • media3-exoplayer-smoothstreaming-1.1.1.aar: 47K

@KrzysztofMoch
Copy link
Member

Yes! This is what I had in mind - I can take care of it
And lets merge this as it is - we will make this in separate PR

@freeboub freeboub merged commit 2285eba into TheWidlarzGroup:master Apr 16, 2024
5 checks passed
This was referenced Apr 16, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

@VMBindraban VMBindraban VMBindraban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freeboub @KrzysztofMoch @VMBindraban