refactor(example): re-init example #3470
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@KrzysztofMoch When building from scratch I still have the build issue: It is really not clear why I have this issue when cloning from scratch, but not on my previously cloned repo :/ transform[stderr]: Could not resolve "/Users/olivier/Documents/GitHub/react-native-video/src/index" in file /Users/olivier/Documents/GitHub/react-native-video/examples/basic/src/VideoPlayer.tsx. error: Error: Unable to resolve module @babel/runtime/helpers/interopRequireDefault from /Users/olivier/Documents/GitHub/react-native-video/src/index.ts: @babel/runtime/helpers/interopRequireDefault could not be found within the project or in these directories: Note: I also think you broken windows sample... it will need a reallignment in the future |
| @@ -1,23 +1,13 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | |||
|
|
|||
| <uses-feature | |||
There was a problem hiding this comment.
can you please revert changes in this file to keep "current" android tv support ?
| "private": true, | ||
| "scripts": { | ||
| "android": "react-native run-android", | ||
| "ios": "react-native run-ios", | ||
| "windows": "react-native run-windows", |
examples/basic/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@react-native-picker/picker": "^1.9.11", | ||
| "@react-native-picker/picker": "react-native-picker/picker", |
There was a problem hiding this comment.
strange, what does it do ?
There was a problem hiding this comment.
I really don't know 😅 i will remove it ...
| "react": "18.2.0", | ||
| "react-native": "0.73.2", | ||
| "react-native-windows": "0.63.41" |
There was a problem hiding this comment.
keep react-native-windows please
|
I will close this one as there is a lot of conflicts and current examples seems to work again |
Summary
To clean code and catch up with newest template I have re-created basic example
NOTE: I remove windows from basic example because it's very heavy - should (will) be moved to separate example
fixes #3469
Changes (PR change log is little mess... 😅)
basicexampleFabricExample&embed-and-fullscreenexamples (basicshould be used to test fabric)Test Plan
yarn installyarn buildyarn xbasic installyarn xbasic android