Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement enterPictureInPictureOnLeave prop for both platform(Android, iOS) #3385

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

feat: implement enterPictureInPictureOnLeave prop for both platform(Android, iOS) #3385

wants to merge 76 commits into from

Commits on Nov 26, 2023

  1. docs: enable Android PIP

    @YangJonghun
    YangJonghun committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    29c35e9 View commit details
    Browse the repository at this point in the history

  2. chore: change comments

    @YangJonghun
    YangJonghun committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e5fd0c7 View commit details
    Browse the repository at this point in the history

  3. feat(android): implement Android PictureInPicture

    @YangJonghun
    YangJonghun committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b554034 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e6797fd View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. refactor: minor refactor code and apply lint

    @YangJonghun
    YangJonghun committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3ba6a30 View commit details
    Browse the repository at this point in the history

  2. fix: rewrite pip action intent code for Android14

    @YangJonghun
    YangJonghun committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4938bd0 View commit details
    Browse the repository at this point in the history

  3. fix: remove redundant codes

    @YangJonghun
    YangJonghun committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    6e8307b View commit details
    Browse the repository at this point in the history

  4. feat: add isInPictureInPicture flag for lifecycle handling 

    - activity provide helper method for same purpose, but this flag makes code simple
    @YangJonghun
    YangJonghun committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0c06c2f View commit details
    Browse the repository at this point in the history

  5. feat: add pipFullscreenPlayerView for makes PIP include video only

    @YangJonghun
    YangJonghun committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f3066a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    60657eb View commit details
    Browse the repository at this point in the history

  2. fix: add manifest value checker for prevent crash

    @YangJonghun
    YangJonghun committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    2872689 View commit details
    Browse the repository at this point in the history

  3. docs: add pictureInPicture prop's Android guide

    @YangJonghun
    YangJonghun committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9723313 View commit details
    Browse the repository at this point in the history

  4. fix: sync controller visibility

    @YangJonghun
    YangJonghun committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    8269546 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. refactor: refining variable name

    @YangJonghun
    YangJonghun committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d10f624 View commit details
    Browse the repository at this point in the history

  2. fix: check multi window mode when host pause 

    - some OS version call onPause on multi-window mode
    @YangJonghun
    YangJonghun committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    05e704d View commit details
    Browse the repository at this point in the history

  3. fix: handling when onStop is called while in multi-window mode

    @YangJonghun
    YangJonghun committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d742b96 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. refactor: enhance PIP util codes

    @YangJonghun
    YangJonghun committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ac4ca79 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge tag 'v6.0.0-beta.5' into feat/android-pip 

    Release v6.0.0-beta.5
    @YangJonghun
    YangJonghun committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7419a81 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    996cb2f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5c5ab63 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Merge tag 'v6.0.0-beta.8' into feat/android-pip 

    Release v6.0.0-beta.8
    @YangJonghun
    YangJonghun committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c1c7625 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    78c2321 View commit details
    Browse the repository at this point in the history

  3. fix: fix FullscreenPlayerView constructor

    @YangJonghun
    YangJonghun committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    cf57475 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. refactor: add enterPictureInPictureOnLeave prop and pip methods 

    - remove pictureInPicture boolean prop
- add enterPictureInPictureOnLeave boolean prop
- add enterPictureInPicture method
- add exitPictureInPicture method
    @YangJonghun
    YangJonghun committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ad06910 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. fix: fix lint error

    @YangJonghun
    YangJonghun committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f75489c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. fix: prevent audio play in background without playInBackground prop

    @YangJonghun
    YangJonghun committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e0795ad View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5ccc997 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. fix: fix onDetachedFromWindow

    @YangJonghun
    YangJonghun committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2c99b61 View commit details
    Browse the repository at this point in the history

  2. docs: update docs for pip

    @YangJonghun
    YangJonghun committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ed77c4c View commit details
    Browse the repository at this point in the history

  3. fix(android): sync pip controller with external controller state 

    - for media session
    @YangJonghun
    YangJonghun committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bf07348 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed May 15, 2024
    Configuration menu
    Copy the full SHA
    f0647da View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. fix(ios): fix pip active fn variable reference

    @YangJonghun
    YangJonghun committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6313b0e View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. refactor(ios): refactor code

    @YangJonghun
    YangJonghun committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6cff2bd View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8f1490a View commit details
    Browse the repository at this point in the history

  2. refactor(android): refactor codes

    @YangJonghun
    YangJonghun committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8cf55f3 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed May 23, 2024
    Configuration menu
    Copy the full SHA
    39988c0 View commit details
    Browse the repository at this point in the history

  2. fix(android): fix lint error

    @YangJonghun
    YangJonghun committed May 23, 2024
    Configuration menu
    Copy the full SHA
    013a69c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5c153ac View commit details
    Browse the repository at this point in the history

  2. refactor(android): refactor android pip logics

    @YangJonghun
    YangJonghun committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2e3b13b View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. fix(android): fix flickering issue when stop picture in picture

    @YangJonghun
    YangJonghun committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5fbede2 View commit details
    Browse the repository at this point in the history

  2. fix(android): fix import

    @YangJonghun
    YangJonghun committed May 27, 2024
    Configuration menu
    Copy the full SHA
    15cd0e8 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. fix(android): fix picture in picture with fullscreen mode

    @YangJonghun
    YangJonghun committed May 30, 2024
    Configuration menu
    Copy the full SHA
    dc6a64e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4a79fd7 View commit details
    Browse the repository at this point in the history

  2. fix(ios): fix syntax error

    @YangJonghun
    YangJonghun committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    edc91d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge tag 'v6.2.0' into feat/android-pip 

    Release v6.2.0
    @YangJonghun
    YangJonghun committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    c552487 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. fix(android): fix Fragment managed code

    @YangJonghun
    YangJonghun committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9c9fe4c View commit details
    Browse the repository at this point in the history

  2. refactor(android): remove redundant override lifecycle

    @YangJonghun
    YangJonghun committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ebb7fbe View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge tag 'v6.3.0' into feat/android-pip 

    Release v6.3.0
    @YangJonghun
    YangJonghun committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ec0c172 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b17a7bd View commit details
    Browse the repository at this point in the history

  2. Merge tag 'v6.4.1' into feat/android-pip 

    Release v6.4.1
    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b4db6da View commit details
    Browse the repository at this point in the history

  3. �fix(js): add PIP type definition for codegen

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a5bff13 View commit details
    Browse the repository at this point in the history

  4. fix(android): fix syntax

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1cd78b4 View commit details
    Browse the repository at this point in the history

  5. chore(android): fix lint error

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c5d9a28 View commit details
    Browse the repository at this point in the history

  6. fix(ios): fix enter background handler

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    053f84c View commit details
    Browse the repository at this point in the history

  7. refactor(ios): remove redundant code

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ae933cb View commit details
    Browse the repository at this point in the history

  8. fix(ios): fix applicationDidEnterBackground for PIP

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    6bbfe82 View commit details
    Browse the repository at this point in the history

  9. fix(android): fix onPictureInPictureStatusChanged

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    d0f521a View commit details
    Browse the repository at this point in the history

  10. fix(ios): fix RCTPictureInPicture

    @YangJonghun
    YangJonghun committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ff25e83 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. refactor(android): Ignore exception for some device ignore pip checker 

    - some device ignore PIP availability check, so we need to handle exception to prevent crash
    @YangJonghun
    YangJonghun committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    b392b75 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a40e66b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. fix(android): add hideWithoutPlayer fn into Kotlin ver

    @YangJonghun
    YangJonghun committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    7952275 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. refactor(android): remove redundant code

    @YangJonghun
    YangJonghun committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8308baa View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Merge tag 'v6.4.3' into feat/android-pip 

    Release v6.4.3
    @YangJonghun
    YangJonghun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    5455d16 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. fix(android): fix pip ratio to be calculated with correct ratio value

    @YangJonghun
    YangJonghun committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    96126be View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Merge tag 'v6.6.2' into feat/android-pip 

    Release v6.6.2
    @YangJonghun
    YangJonghun committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f376b53 View commit details
    Browse the repository at this point in the history

  2. fix(android): fix crash issue when unmounting in PIP mode

    @YangJonghun
    YangJonghun committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    362459d View commit details
    Browse the repository at this point in the history

  3. fix(android): fix lint error

    @YangJonghun
    YangJonghun committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    7e8a0b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge tag 'v6.6.3' into feat/android-pip 

    Release v6.6.3
    jonghun committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2c78d41 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Merge branch 'master' into feat/android-pip

    @freeboub
    freeboub authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    74abd7f View commit details
    Browse the repository at this point in the history

  2. Update android/src/main/java/com/brentvatne/react/VideoManagerModule.kt

    @freeboub
    freeboub authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9c805d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8e132c3 View commit details
    Browse the repository at this point in the history

  2. fix(android): fix lint error

    @YangJonghun
    YangJonghun committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d712690 View commit details
    Browse the repository at this point in the history

  3. fix(ios): fix lint error

    @YangJonghun
    YangJonghun committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    441fb56 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge branch 'master' into feat/android-pip

    @YangJonghun
    YangJonghun committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c431403 View commit details
    Browse the repository at this point in the history

  2. fix(ios): fix lint error

    @YangJonghun
    YangJonghun committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    42b2477 View commit details
    Browse the repository at this point in the history

  3. feat(expo): add android picture in picture config within expo plugin

    @YangJonghun
    YangJonghun committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    a4381e4 View commit details
    Browse the repository at this point in the history