Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exoplayer: Use same okhttp version as RN #2340

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Exoplayer: Use same okhttp version as RN #2340

merged 1 commit into from
Apr 8, 2021

Commits on Apr 6, 2021

  1. Exoplayer: Use okhttp version specified in gradle.properties 

    Because React Native uses okhttp, including exoplayer causes apps to use two different versions of okhttp.  This results in some unpredictable behavior.  Clients of `react-native-video` should be able to specify the same OKHTTP version to react-native and react-native video.

See where it's specified in react-native trunk: 
- https://github.com/facebook/react-native/blob/master/ReactAndroid/gradle.properties#L15
- https://github.com/facebook/react-native/blob/e1b6cd3f756aa034b11af6bf9960efb42bde8692/ReactAndroid/build.gradle#L452-L453
    @wildseansy
    wildseansy authored Apr 6, 2021
    Configuration menu
    Copy the full SHA
    18323a2 View commit details
    Browse the repository at this point in the history