Using RNVSimpleCache.INSTANCE for HlsMediaSource.Factory (HLS Caching on Android)

[IslamRustamov]

As we know - this library does not support HLS video caching on Android.

So, I dug deeper into the source code of this lib and found out in ReactExoplayerView.java in buildMediaSource method (line 1053) this line:

mediaSourceFactory = new HlsMediaSource.Factory(
    mediaDataSourceFactory
).setAllowChunklessPreparation(source.getTextTracksAllowChunklessPreparation());

can actually be changed to this:

mediaSourceFactory = new HlsMediaSource.Factory(
        RNVSimpleCache.INSTANCE.getCacheFactory(buildHttpDataSourceFactory(true))
).setAllowChunklessPreparation(source.getTextTracksAllowChunklessPreparation());

And after this change - i checked network inspector in Android Studio and saw that my HLS videos are not being downloaded again (presumably, they are being saved to cache).

So, why didn't authors of this package made this available for HLS video caching if it seems rather easy to do? What are the drawbacks of this? (I'm not proficient in Android development, so maybe the change I did is a bad thing to do)

[freeboub]

If I remember well the SimpleCache was working only with mp4. I reviewed the doc again and I don't see this limitation anymore! So I think your change can be integrated without problem! If you want to create a pull request with this change, it's welcome!

[IslamRustamov]

Thanks! Check it out #4272