fix(ios): fix pip memory leak

TheWidlarzGroup · Jan 29, 2024 · 850a4e6 · 850a4e6
1 parent 2094dbd
commit 850a4e6
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/ios/Video/RCTVideo.swift b/ios/Video/RCTVideo.swift
@@ -140,7 +140,14 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
         _eventDispatcher = eventDispatcher
 
         #if os(iOS)
-            _pip = RCTPictureInPicture(self._onPictureInPictureStatusChanged, self._onRestoreUserInterfaceForPictureInPictureStop)
+            _pip = RCTPictureInPicture(
+                { [weak self] in
+                    self?._onPictureInPictureStatusChanged()
+                },
+                { [weak self] in
+                    self?._onRestoreUserInterfaceForPictureInPictureStop()
+                }
+            )
         #endif
 
         NotificationCenter.default.addObserver(
@@ -193,6 +200,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
     deinit {
         NotificationCenter.default.removeObserver(self)
         self.removePlayerLayer()
+        _pip = nil
         _playerObserver.clearPlayer()
     }