-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix switch camera #6613
Fix switch camera #6613
Conversation
Is the clicking allow each time because of your set up or do you have to do that per camera? |
I think it's my setup |
I have a feeling its every time you run |
Might be. Let me test. |
Cool! Can we put the button on top of the camera stream instead? Right now it's causing this black bar at the bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though haven't tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok,
Iphone 14 pro - chrome and safari - testing
- switch camera button still does not show on first render of the modal
- switching the camera works once to go from back camera to front
- but clicking the button again does nothing
I'm thinking we should put a component in between two we currently have. This one would specifically handle requesting the stream etc and includes the switching button, then we re-render the a component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still broken but going ahead anyway.
I don't have an android phone to test, but I believe the switch button not rendering will be there as well, so I don't think anyone will see it anyway
Summary
References #6529
Changes
test.mp4
Testing
Notes for Reviewers
Not using
stream
for conditions because at some point in time it is an empty object, which prevents comparing it's contents and makes it unreliable for the switch.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.