Skip to content

Sensocon fix pr 1 #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sensocon fix pr 1 #945

wants to merge 4 commits into from

Conversation

@jenkinsheath
Copy link

@jenkinsheath jenkinsheath commented Aug 12, 2025 •
edited
Loading

Summary

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

jenkinsheath
jenkinsheath commented Aug 21, 2025
View reviewed changes
Copy link
Author

@jenkinsheath jenkinsheath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed all requested changes and believe that this is ready to be approved. Thank you -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jaime-Trinidad Jaime-Trinidad Awaiting requested review from Jaime-Trinidad Jaime-Trinidad is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jenkinsheath