Added WS558, EM310, AM300 and Updated old description #354
Conversation
|
Is help needed? I can gladly provide some support at this PR. |
Yes, please! Your help is much appreciated. |
|
Hi @Milesight-IoT, I opened a PR to your repo. |
|
@Milesight-IoT I finish the complete review, speaking with the team, is necessary to make a rollback in some changes to the firmware and hardware version, it means the ones already in the Repository must stay like this, and add the new ones, not replacing the old ones, the reason is there are users with this versions and they will change to the new firmware version when it is available for them, and making the change taking out the old one can cause problems to them. I will add each comment in the codec files because many outputs don't correspond to the bytes inputs. |
|
Hi @Milesight-IoT any update here? It will be great we can merge these sensors |
|
The problem in em300-mcs should be about door the parameter that EM300-MCS uses to check current door status, I commented the lines with door but there still seems to be problems unresolved. Kindly help and check if that's stopping validation. Thanks very much. @Jaime-Trinidad |
|
Speaking of rolling back some files, could you please tell me specifically which .yaml I should dublicate instead of replacing the old ones? @Jaime-Trinidad |
|
Hi Jaime, Until 4th Batch Update, there are only 2 models left from us due to unsure information, they are UC50x and UC51x. Besides there are discontinued products UC1114, UC1122, UC1152, there might be customers using them on TTN but we don't sell them or have their product URL any more. Would you suggest that I should create the files for them and leave URLs blank? Waiting for your reply, thanks. |
|
@Milesight-IoT can you first rebase this and resolve conflicts? Also why is |
|
Hi @johanstokking , I mended the conflicting files by copying latest vendor\index.yaml and collating some details in em300-mcs files. But there still seems to be conflicts, could you please check and show me what exactly they are? Many thanks. |
| @@ -0,0 +1,92 @@ | |||
|
|
|||
| function decodeUplink(input) { | |||
There was a problem hiding this comment.
Please don't use & in filenames
There was a problem hiding this comment.
OK, noted. May I know what's the suggested filename to use if we provide AM103 and AM103L and they share the same codec and decoder?
There was a problem hiding this comment.
You can do dashes or underscores
Hi @johanstokking, issues about the filename should have been resolved. Could you please check out this question about Milesight discontinued products? |
Thanks. Yes, please make sure that you don't remove products from the Device Repository. Indeed, if you don't sell them anymore, you can remove URLs. We may add a field to indicate that the device has been discontinued or superseded by another device in the future. This branch is still not rebased. Please rebase on latest master. |
|
Hi @johanstokking I've rebased on latest master, will add the discontinued devices soon. |
|
Thanks @Milesight-IoT. @Jaime-Trinidad will pick this up when you're done. |
4 participants
Summary
Added WS558, EM310, AM300 and Updated old description
Changes
Notes for Reviewers
Milesight IoT is releasing some new models of LoRa end-devices, this pull request contains the ones that haven't been added in the repository yet for users of TTI to choose.
We noticed device models added in last pull request aren't available on TTI when adding one, kindly help on the issue and review this request to implement Milesight IoT models.