Skip to content

Set motion flag before callback #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2020
Merged

Set motion flag before callback #26

merged 2 commits into from
Feb 7, 2020

Conversation

rgm3
Copy link
Contributor

@rgm3 rgm3 commented Feb 7, 2020

Resolves #25

rgm3 added 2 commits February 6, 2020 19:46
@rgm3
Allow detecting isMoving within onMotionStart cb
9dc0aba 
Set the flag indicating motion state before calling the
onMotion callback functions.  Otherwise, `node->isMoving()`
unexpectedly returns false from within the callback.

Resolves TheThingsNetwork#25
@rgm3
Replace reference to missing setMotion function
41b9b4e
@claassistantio
Copy link

claassistantio commented Feb 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@johanstokking johanstokking self-requested a review February 7, 2020 11:03
@johanstokking johanstokking self-assigned this Feb 7, 2020
johanstokking
johanstokking approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanstokking johanstokking merged commit 6172938 into TheThingsNetwork:master Feb 7, 2020
@johanstokking
Copy link
Member

Thanks, released in https://github.com/TheThingsNetwork/arduino-node-lib/releases/tag/v2.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

Assignees

@johanstokking johanstokking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isMoving always false within onMotionStart callback
3 participants
@rgm3 @claassistantio @johanstokking