[Stubbjax]

This change fixes an issue where the Rocket Buggy missile's primary damage was not being consistently applied to various targets.

Overlapping object radii trigger a collision, but the Rocket Buggy missile's PrimaryDamageRadius of 0 is smaller than its GeometryMajorRadius of 2. Because the damage calculation can fall outside of the target’s collision bounds, targets may register only 5 damage instead of the expected 20.

This issue mainly affects circular geometry and has relatively little to no impact against most units and buildings. A PrimaryDamageRadius of 2 to match the GeometryMajorRadius is prioritised over the typical 5 of other rocket weapons to minimise impact elsewhere.

The below image represents a Rocket Buggy missile that has overlapped and thus collided with a Tunnel Network, however the primary damage is only applied at the exact centre of the missile, which is outside the Tunnel's collision bounds.

Before

Two Rocket Buggies take vastly different times to destroy a Tunnel Network

BEFORE.mp4

After

Damage is now always consistent

AFTER.mp4

[xezon]

Does this also fix the issue where the out-of-reach Reinforcement Pad is not hit? There is a bug report for it in Patch 1.

[Stubbjax]

Does this also fix the issue where the out-of-reach Reinforcement Pad is not hit? There is a bug report for it in Patch 1.

That is more closely related to TheSuperHackers/GeneralsGamePatch#1700. I have a fix at Stubbjax/fix-fuel-depleted-rocket-destruction but need to get back to testing it.

[xezon]

Are there other missiles where the PrimaryDamageRadius is smaller than the missile geometry?

Maybe in Code we could also add a DEBUG_LOG for this setup mistake.

[xezon]

Makes sense.

[Stubbjax]

Are there other missiles where the PrimaryDamageRadius is smaller than the missile geometry?

I added your log suggestion to the code which detected the following cases:

• BuggyRocketWeapon
• CINE_BuggyRocketWeapon
• BuggyRocketWeaponUpgraded
• GC_Slth_GLAJarmenKellRifle
• BuggyRocketREDWeapon

I've added BuggyRocketREDWeapon to this change and will open a code PR for the logging.