[Stubbjax]

This change fixes an issue where firestorms would only repeat the fade-in portion of the audio loop.

Before

BEFORE.mp4

After

AFTER.mp4

[xezon]

Maybe fix all misspelled audio files ones in go?

See: TheSuperHackers/GeneralsGamePatch#1913

Note that Patch 1 has seen a huge amount of audio fixes and ideally they are carried over to Patch 2.

[Stubbjax]

Maybe fix all misspelled audio files ones in go?

Hmm, I suppose we can. But on the other hand, grouping audio fixes in the one change feels like more of a technical approach when these types of changes should be more distinct and tailored to the end user (e.g. where is the connection between a Ranger getting a new voice line and fixing the firestorm looping audio?).

The referenced change is also not all-encompassing and doesn't capture sounds that exist but are incorrect, or sounds that are simply missing or disabled.

[xezon]

Hmm, I suppose we can. But on the other hand, grouping audio fixes in the one change feels like more of a technical approach when these types of changes should be more distinct and tailored to the end user (e.g. where is the connection between a Ranger getting a new voice line and fixing the firestorm looping audio?).

It will be a lot of work to do each of these per unit or so. There are hundreds of audio mistakes. My expectation when doing it that some mistakes will be overlooked, because it is humanly unlikely to open 500 Pull requests and not forget one.

The referenced change is also not all-encompassing and doesn't capture sounds that exist but are incorrect, or sounds that are simply missing or disabled.

Yes, but there are other pulls that do other classes of fixes. The logic was the separate them by kind of error.

[Stubbjax]

It will be a lot of work to do each of these per unit or so. There are hundreds of audio mistakes. My expectation when doing it that some mistakes will be overlooked, because it is humanly unlikely to open 500 Pull requests and not forget one.

Perhaps instead of grouping them by the kind of error, they can be grouped by the type of audio. Or we could just group the unit voice lines; e.g. ideally the Ranger's "We'll lead the way" voice line is grouped with the "Little house party" voice line.

Also keep in mind that fixes like the firestorm are objective improvements whereas some other sound fixes could be more subjective, so it might make more sense to keep them separate in that regard.