Skip to content

Made lines with numbers of 1000 and 10000 consistent across all languages #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dmgreeny
Copy link
Collaborator

As discussed here #2633

@dmgreeny dmgreeny added Text Is text, string, localization related Minor Severity: Minor < Major < Critical < Blocker labels Mar 12, 2025
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comment to top of file about which language numbers were polished.

@@ -101173,33 +101173,33 @@ END

// context: Tooltip displayed when the user mouses over the Streak 5 battle honor icon
TOOLTIP:BattleHonorStreak5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bottom 4 strings need to be documented that all languages except DE were added by us.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fixed

US: "Streak Honor\nPlayer has won 10 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins"
DE: "Siegesmedaille\nDer Spieler hat 10 Gefechte in Folge gewonnen.\nFür 3, 10, 25, 100, 500 & 1000 Siege in Folge bekommst du jeweils eine Medaille."
FR: "Distinction d'enchaînement\nLe joueur a remporté 10 parties Escarmouche d'affilée.\nGagnez une nouvelle récompense pour 3, 10, 25, 100, 500 et 1000 victoires consécutives."
US: "Streak Honor\nPlayer has won 10 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1,000 consecutive wins"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the number comma really make sense? Commas are already used for the number list.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you propose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it, just raising that it perhaps is odd. Maybe a native US person can give their 2 cents on this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added "," to US 1000, because in one of the original text lines it was written as 10,000

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChatGPT response:
In U.S. English, it's standard to use a comma in numbers 1,000 and above (e.g., 1,000; 10,000; 100,000). So your text is correct as is.

However, some style guides (like in coding or scientific contexts) might omit the comma for readability or consistency (e.g., 1000 instead of 1,000). But in general writing, especially for things like game achievements, the comma is preferred.

DE: "Vorherrschaftsmedaille\nDer Spieler hat über 100 Gefechte gewonnen. Nach 100, 500, 1000 und 10.000 Siegen bekommst du eine Medaille."
FR: "Distinction de domination\nLe joueur a remporté plus de 100 parties Escarmouche.\nGagnez une nouvelle récompense pour 100, 500, 1000 et 10 000 victoires consécutives."
US: "Domination Honor\nPlayer has won over 100 Skirmish games\nEarn a new medal for 100, 500, 1,000 and 10,000 lifetime wins"
DE: "Vorherrschaftsmedaille\nDer Spieler hat über 100 Gefechte gewonnen. Nach 100, 500, 1,000 und 10,000 Siegen bekommst du eine Medaille."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dot makes more sense for German numbers.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So make it 1.000 and 10.000 for German?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think the dot is ok for German.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator Author

@dmgreeny dmgreeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed and ready for merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants