Skip to content

Fix: Set better name for China Helix in Polish strings #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

xezon
Copy link
Contributor

@xezon xezon commented Aug 21, 2023

This change sets appropriate name for China Helix in Polish strings. It is now called "Helis" instead of "Spiral".

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker China Affects China faction Text Is text, string, localization related labels Aug 21, 2023
@xezon xezon changed the title Fix: Sets appropriate name for China Helix in Polish strings Fix: Set better name for China Helix in Polish strings Aug 21, 2023
@xezon xezon force-pushed the text-polish-helix-name branch from ae90b9d to 39191d8 Compare August 21, 2023 16:12
@xezon xezon force-pushed the text-polish-helix-name branch from 39191d8 to b5ae138 Compare August 27, 2023 12:09
@xezon xezon force-pushed the text-polish-helix-name branch from b5ae138 to 0854bc0 Compare August 27, 2023 12:18
@xezon
Copy link
Contributor Author

xezon commented Aug 27, 2023

Need to have a Polish guy one day who can double check the polish edits. But for now looks ok. Documentation added.

@xezon xezon merged commit 8f1ff0d into main Aug 27, 2023
@xezon xezon deleted the text-polish-helix-name branch August 27, 2023 12:23
Copy link

@CrabHead CrabHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR. Needs some changes, mainly from "Helisi" to "Helisy". Other than that all is correct

@@ -43260,7 +43261,7 @@ IT: "Permette a questo Helix di sganciare bombe al napalm."
KO: "이 헬릭스의 네이팜탄 폭격을 가능하게 합니다."
ZH: "讓螺旋直昇機擁有汽油彈投擲能力"
BP: "Habilite este Helix para lançar bombas de napalm."
PL: "Umożliwia tej Spirali zrzucanie bomb z napalmem"
PL: "Umożliwia tej Helisi zrzucanie bomb z napalmem"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@@ -43274,7 +43275,7 @@ IT: "Permette a questo Helix di sganciare bombe nucleari."
KO: "이 헬릭스의 핵폭탄 폭격을 가능하게 합니다."
ZH: "讓螺旋直昇機擁有核彈投擲能力"
BP: "Habilite este Helix para lançar bombas nucleares."
PL: "Umożliwia tej Spirali zrzucanie atomówek"
PL: "Umożliwia tej Helisi zrzucanie atomówek"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@@ -44021,7 +44022,7 @@ IT: "Cannone gatling Helix"
KO: "헬릭스 개틀링 캐논"
ZH: "螺旋直昇機蓋特機砲"
BP: "Canhão Gattling do Helix"
PL: "Działko gattling Spirali"
PL: "Działko gattling Helisi"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "gattling" to "gatling" and "Helisi" to "Helisy"

@@ -44035,7 +44036,7 @@ IT: "Diffusore Helix"
KO: "헬릭스 프로퍼갠더 타워"
ZH: "螺旋直昇機思想強化電塔"
BP: "Torre de Propaganda do Helix"
PL: "Megafon Spirali"
PL: "Megafon Helisi"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@@ -44049,7 +44050,7 @@ IT: "Bunker da battaglia Helix"
KO: "헬릭스 배틀 벙커"
ZH: "螺旋直昇機碉堡"
BP: "Bunker de Combate do Helix"
PL: "Bunkier bojowy Spirali"
PL: "Bunkier bojowy Helisi"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@@ -50396,7 +50397,7 @@ IT: "Costruisce un Cannone gatling su questo Helix."
KO: "이 헬릭스에 개틀링 캐논을 만듭니다."
ZH: "在螺旋直昇機上增設蓋特機砲"
BP: "Equipa este Helix com um Canhão Gattlin"
PL: "Uzbrojenie Spirali w działko gattling"
PL: "Uzbrojenie Helisi w działko gattling"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@@ -50410,7 +50411,7 @@ IT: "Costruisce un Diffusore su questo Helix."
KO: "이 헬릭스에 프로퍼갠더 타워를 만듭니다."
ZH: "在螺旋直昇機上增設思想強化電塔"
BP: "Equipa este Helix com uma Torre de Propaganda"
PL: "Wyposażenie Spirali w megafony"
PL: "Wyposażenie Helisi w megafony"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@@ -50424,7 +50425,7 @@ IT: "Costruisce un Bunker su questo Helix, che può essere occupato da truppe in
KO: "이 헬릭스에 벙커를 건설합니다. 벙커에는 부대가 주둔합니다.\n부대는 벙커 밖으로 사격을 할 수 있습니다."
ZH: "在螺旋直昇機上增設碉堡,碉堡可讓您的士兵進駐,士兵可從碉堡內對外開火"
BP: "Equipa este Helix com um Bunker. Os Bunkers podem ser ocupados por soldados. Os soldados podem disparar dos Bunkers"
PL: "Wyposażenie Spirali w bunkier. Bunkier może być obsadzony żołnierzami, którzy mogą się wtedy ostrzeliwać"
PL: "Wyposażenie Helisi w bunkier. Bunkier może być obsadzony żołnierzami, którzy mogą się wtedy ostrzeliwać"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "Helisi" to "Helisy"

@dmgreeny
Copy link
Collaborator

dmgreeny commented Mar 5, 2025

This change was additionally improved here #2635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
China Affects China faction Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants