Added Checklist to Templates #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to move the checklist feature out of the MDList object to maintain its vanilla purity. In other words, if folks want extend markdown features, they should be able to find them in Templates 100% of the time. I like this from a consistency standpoint, so folks always know where to look.
In the short term, I am only deprecating the checklist feature in MDList. It will likely stick around for at least another version or two of SnakeMD, but I will need to eventually phase it out.
I'm am a fan of this change because it does simplify the code in MDList quite a bit! The Checklist wrapper just has to handle the checkboxes, which is nice.