Fix FileSink Logger #45
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This block used to error out saying arg two was a string, but an integer was expected, this displays the error.
The directory already existing is a windows requirement The file permissions used to be `rwxr-xr-x`, but logs don't need most of that. 0 is the default file creation mode in linux and windows
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block with the error used to throw a message when booting neovim saying
bad argument #2 to 'error' (number expected, got string). This fixes that.I added directory creation logic because it's required for Windows.
The permissions for the log files were throwing errors in Windows and are probably not right for log files in Linux. The file permissions used to be
rwxr-xr-x, but logs don't need executable.