Fix compilation with -Wtype-limits
#1621
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI currently fails, because of a check if an unsigned integer is greater or equal to zero. This PR removes the check, getting rid of a warning in GCC and making CI green.
Clang emits a similar warning if
-Wtype-limits
is passed (enabling-Wtautological-unsigned-zero-compare
), which isn't enabled through-pedantic -Wpedantic -Wall -Wextra -Werror
(thus Apple-Clang doesn't complain).Aside:
All
.clang-format
s are currently broken [at least with 18.1], because of a duplicateAfterStruct
.Diff