Update poetry to 1.2.1 #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Convert this to a draft since tests are failing. Will have to debug whats going on here. |
tdilauro
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the version of Poetry we are using in Docker and CI to 1.2.1.
Homebrew on my system updated Poetry to 1.2.1 today, then when I committed a update to a poetry lock file all of a sudden setuptools was being uninstalled by poetry. Apparently lock files generated by poetry 1.2.1 are not compatible with 1.1.x and will cause setuptools to be uninstalled
python-poetry/poetry#4242
Motivation and Context
It seems reasonable to update the version of poetry we use, since 1.2 can read lock files from 1.1, but 1.1 can't correctly read lock files generated by 1.2.
How Has This Been Tested?
Compared the packages we installed with Poetry 1.1 vs Poetry 1.2 by hand. CI running and building a docker container should show that this is working.
Checklist