Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP Core Roundup 16 #99

Merged
merged 9 commits into from
Sep 1, 2023
Merged

Add PHP Core Roundup 16 #99

merged 9 commits into from
Sep 1, 2023

Conversation

saundefined
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 09:32 Inactive
@Ayesh
Copy link
Collaborator

Ayesh commented Aug 25, 2023

Oh wow this is awesome, thank you so much! I will prepare the commit list right away.

Copy link
Collaborator

@Ayesh Ayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit list so far, but I guess it is too early for now.

I updated https://git.sr.ht/~ayesh/php-src-commit-formatter to v2, that uses GitHub API to fetch commits, format them, group them by the author name, adds our purple hearts for the foundation team, and adds links/code tags where possible. Improved highlighting too.

@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 11:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 11:49 Inactive
Copy link
Collaborator

@Ayesh Ayesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voting started today :)

Co-authored-by: Ayesh Karunaratne <Ayesh@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pull request August 27, 2023 10:16 Inactive
source/_posts/2023-09-01-php-core-roundup-16.md Outdated Show resolved Hide resolved
source/_posts/2023-09-01-php-core-roundup-16.md Outdated Show resolved Hide resolved
tweets/2023-09-01_roundup_16_announce.tweet Outdated Show resolved Hide resolved
Co-authored-by: Roman Pronskiy <root@pronskiy.com>
@github-actions github-actions bot temporarily deployed to pull request August 28, 2023 12:29 Inactive
@pronskiy
Copy link
Member

pronskiy commented Aug 30, 2023

Hey guys, what do you think about adding a section about documentation this time?
There are two nice updates to mention:

@saundefined
Copy link
Collaborator Author

Hey guys, what do you think about adding a section about documentation this time?

Sounds good to me

@Ayesh
Copy link
Collaborator

Ayesh commented Aug 31, 2023

I don't think we will see the PDO Subclass RFC will be merged for PHP 8.3, so perhaps we can mention it in the RFCs list? What do you think?


Merging postponed: [PDO driver specific sub-classes](https://wiki.php.net/rfc/tempnam-suffix-v2) by Danack

This RFC proposed to introduce driver-specific \PDO sub classes so applications can granular declare the specific PDO drivers they support.

This RFC vote was completed and accepted unanimously, but due to the implementation complexity, the changes for this RFC were not finalized before the PHP 8.3.0RC1 release. Because PHP 8.3 is beyond its feature-freeze and now that the first release candidate is released, the consensus seems to be that this RFC will not be implemented in PHP 8.3 but on the next PHP version.


Co-authored-by: Ayesh Karunaratne <Ayesh@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pull request August 31, 2023 12:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 31, 2023 12:32 Inactive
@nielsdos
Copy link
Contributor

Does the commit list include all commits since last roundup? It seems some commits from the first few days of August are missing?

@github-actions github-actions bot temporarily deployed to pull request August 31, 2023 17:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 31, 2023 18:13 Inactive
@saundefined
Copy link
Collaborator Author

Does the commit list include all commits since last roundup? It seems some commits from the first few days of August are missing?

Updated a bit in 879cab3

@github-actions github-actions bot temporarily deployed to pull request August 31, 2023 18:17 Inactive
@nielsdos
Copy link
Contributor

Updated a bit in 879cab3

Cool, thanks!

@github-actions github-actions bot temporarily deployed to pull request September 1, 2023 13:50 Inactive
@pronskiy pronskiy marked this pull request as ready for review September 1, 2023 13:51
@pronskiy pronskiy merged commit 2615ead into ThePHPF:main Sep 1, 2023
3 checks passed
@saundefined saundefined deleted the roundup/16 branch September 1, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants