switched code highlighting from js to php implementation #153
Conversation
|
🚀 Deployed on https://deploy-pr-153--thephpfoundation.netlify.app |
Pekhov14
force-pushed
the
switch-highlight-from-js-to-php
branch
from
88b86fa
to
6db437a
Compare
Pekhov14
force-pushed
the
switch-highlight-from-js-to-php
branch
from
6db437a
to
142533a
Compare
|
Hi, I love the idea, thanks! Can you take a look at syntax highlighting in blocks? e.g. |
Can be used with or without language indication 1) ```php 2) ```
Pekhov14
force-pushed
the
switch-highlight-from-js-to-php
branch
from
62b9196
to
7707230
Compare
Hi, I made some corrections. But this example with Fibonacci is not the library's strong suit; it looks much better with other examples. e.g https://deploy-pr-153--thephpfoundation.netlify.app/blog/2022/11/30/php-core-roundup-8/ |
|
@pronskiy |
|
@Pekhov14, Thanks a lot for updating the implementation. Though it looks like it does not render the blocks correctly: I was trying to reformat the blocks a bit to make it look good, but still it's a bit unreliable. |
| "repositories": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/pekhov14/sculpin" |
There was a problem hiding this comment.
Do you plan on maintaining this fork? I don't think it's a good idea for the website to depend on "dev-main" on a third party composer repo like this. If you intend to maintain this fork, register it under a different vendor name on packagist.org? Or better yet get this merged into sculpin itself? Either way I don't think this reference to a third party repo overwriting sculpin is a good idea to merge into the php foundation website.
There was a problem hiding this comment.
@naderman Yes, I made a pull request and it was accepted, I will update the code soon.
|
@Pekhov14 I'm closing this for now as paused. Feel free to reopen when ready. |
No description provided.