Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Twitter icon with X #103

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

saundefined
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

@github-actions github-actions bot temporarily deployed to pull request September 7, 2023 08:41 Inactive
@sebastianbergmann
Copy link
Collaborator

I think we should have a discussion whether we still want to use that platform at all.

@pronskiy
Copy link
Member

@saundefined how about moving icon to an svg file?

@github-actions github-actions bot temporarily deployed to pull request September 14, 2023 19:01 Inactive
@saundefined
Copy link
Collaborator Author

Noticed that Matthew Weier O'Phinney changed Twitter to Mastodon - corrected the link.

how about moving icon to an svg file?

I think it's easier to control the behavior now with fill="currentColor", if you think a svg icon would be better, I'll update

@pronskiy pronskiy merged commit bac138c into ThePHPF:main Sep 14, 2023
4 checks passed
@saundefined saundefined deleted the twitter-to-x branch September 14, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants