feat: Control features with build arg#75
Open
AaronBenDaniel wants to merge 5 commits intofeature/#80-dockerfilefrom
Open
feat: Control features with build arg#75AaronBenDaniel wants to merge 5 commits intofeature/#80-dockerfilefrom
AaronBenDaniel wants to merge 5 commits intofeature/#80-dockerfilefrom
Conversation
TheOnlyWayUp
requested changes
Jun 24, 2025
Collaborator
Author
|
What about the |
Owner
|
Rebasing to #82. 82 will be merged to master first, and this branch will be next. |
TheOnlyWayUp
force-pushed
the
feature/#74-unified-feature-branch
branch
2 times, most recently
from
6822fb0 to
ec16efe
Compare
Owner
|
Rebased the 3 commits on this branch onto 82. |
TheOnlyWayUp
force-pushed
the
feature/#74-unified-feature-branch
branch
from
ec16efe to
2956399
Compare
Collaborator
Author
|
This branch is broken if #82 is merged. Fixes will need to be made before this can get merged into master. |
Collaborator
Author
|
I believe this branch is ready to merge. @TheOnlyWayUp can you review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74.
Merges PDF and non-PDF branches and controls which features are enabled with a build argument.
By default, PDF downloads, the donator frontend, and unlimited bandwidth are disabled. If, while running
docker build,--build-arg feature_flag=true--build-arg pdfs=trueis added, the features will be enabled.