Skip to content

Knights Travails: Remove explicit instruction on search algorithm and implementation#31236

Open
mao-sz wants to merge 2 commits into
TheOdinProject:mainfrom
mao-sz:knight-travail-search
Open

Knights Travails: Remove explicit instruction on search algorithm and implementation#31236
mao-sz wants to merge 2 commits into
TheOdinProject:mainfrom
mao-sz:knight-travail-search

Conversation

@mao-sz

@mao-sz mao-sz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Because

#29827 added explicit instruction to use BFS as a "helpful tip", though this directly conflicts with the assignment step to think through DFS and BFS and decide which to use.

I firmly believe that though it's a tricky project, this is still an extremely important learning opp that shouldn't be spoilt (both deciding between the algos and thinking through implementation - learners have been exposed to BFS and DFS implementations before). I do think the original wording is a little vague though (I've come across plenty who'd over-think "search algorithm" and miss that it essentially refers to DFS/BFS).

Other problems include stating that visited positions need tracking - this is only required for DFS and is only an optimisation for BFS. This IMHO is a big part of understanding DFS and BFS, when someone realises how BFS doesn't actually require it.

Landing #30700 will also help learners a lot in the long run, though I believe this PR should be a good middle ground that doesn't need to be blocked until that lands.

This PR

For both pathways' KT projects:

  • Removes section explicitly instructing what to use
  • Rephrases assignment step for clarity on search algos and key considerations
  • Fixes heading case and unnecessary indentations

Issue

Closes #29783

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

mao-sz added 2 commits July 13, 2026 01:39
Part of the pedagogy is thinking through how DFS and BFS actually work.
Giving things away shortcuts that.
@mao-sz
mao-sz requested review from a team and 01zulfi and removed request for a team July 13, 2026 00:52
@github-actions github-actions Bot added Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: JavaScript Involves the JavaScript course Content: Ruby Involves the Ruby course

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Knights Travails: Clarify BFS for grids in Knight’s Travails

1 participant