Skip to content

Foundations: Replace calculator demo project link with corrected version #29748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

G-O-T-W
Copy link
Contributor

@G-O-T-W G-O-T-W commented May 28, 2025

Because

The previously linked calculator project had a display overflow issue when users entered long sequences of digits without using operators. Additionally, it did not handle double operator presses correctly, which contradicts the updated project instructions.

This PR

  • Replaces the old calculator demo link with a new one that:
    • Prevents display overflow when entering long numbers.
    • Handles consecutive operator inputs properly, matching updated requirements.
    • Fully adheres to the project's functional expectations.

Issue

Closes #29322

Additional Information

This update improves the quality and reliability of the demo for learners, ensuring the example aligns with the behavior expected by the curriculum's instructions.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label May 28, 2025
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @G-O-T-W

@KevinMulhern KevinMulhern merged commit 76a036a into TheOdinProject:main May 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculator: The student's project linked has overflowing display
2 participants