Feature/extend build dependency #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the header only fmt lib is used to show this
doctest_discover_tests() is only availabe if doctest is not imported with find_packag()
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 12 12
=========================================
Hits 12 12
Continue to review full report at Codecov.
|
ClausKlein
changed the title
TheLartians
requested changes
Feb 11, 2021
There was a problem hiding this comment.
Hey, thanks for the PR! I do like the idea of adding an example C++ dependency to the main library. Some points should be addressed though, as I'd like to keep the starter as simple and general as possible. Note that a lot is personal preference, which is why we encourage users to create their own forks with their personal modifications.
respect most review comments
no default cxx language settings install fmt link against fmt::fmt export dependency too if not needed ...
TheLartians
reviewed
Feb 16, 2021
Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
update to current PackageProject version 1.5.0 too
TheLartians
requested changes
Feb 16, 2021
Co-authored-by: Lars Melchior <TheLartians@users.noreply.github.com>
remove NOLINT comment
ClausKlein
commented
Feb 18, 2021
needs to use doctest cmake modules ... it is not my idea!
TheLartians
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add build time dependency to static lib Greeter
this also prevents this #79 issue