New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Greeter link privately to fmt #109

Merged

TheLartians merged 1 commit into TheLartians:master from hazelnusse:fmt_private_link

Mar 21, 2021

Contributor

hazelnusse commented Mar 21, 2021

Greeter depends on fmt only in it's implementation file, therefore this
dependency can be private.


          Make Greeter link privately to fmt

a44d35f

Greeter depends on fmt only in it's implementation file, therefore this
dependency can be private.

Owner

TheLartians commented Mar 21, 2021

Agreed, this is a better practice. thanks!

TheLartians approved these changes

View reviewed changes

TheLartians merged commit 9e54d3c into TheLartians:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet