Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of attachment in subattribute #17

Closed
To-om opened this issue Jun 22, 2017 · 0 comments
Closed

Support of attachment in subattribute #17

To-om opened this issue Jun 22, 2017 · 0 comments
Assignees
Milestone

Comments

@To-om
Copy link
Contributor

To-om commented Jun 22, 2017

JsonInputValue is the sole InputValue that support subattribute, so attachments are mandatory in the top level fields.

Attachment can be created from FileInputValue (FIV) or from AttachmentInputValue (AIV). The idea is to permit to create AIV from Json. FIV must not be created from Json because FIV contains a reference to a file on disk and may cause security risk.
Json representation of AIV should be provided by service layer, not from the http request as it references already stored attachment in datastore and must contain coherent data (in particular hashes).

@To-om To-om added this to the 1.2.0 milestone Jun 22, 2017
@To-om To-om self-assigned this Jun 22, 2017
@To-om To-om closed this as completed Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant