Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong data volume mapping for thehive4 docker-compose #1582

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Wrong data volume mapping for thehive4 docker-compose #1582

merged 1 commit into from
Nov 19, 2020

Conversation

KaanSK
Copy link
Contributor

@KaanSK KaanSK commented Oct 16, 2020

TheHive application.conf points to /opt/data for file storage but docker-compose file mounts to /data. This commit fixes the mapping.

@KaanSK
Wrong data volume mapping for thehive
4e4da20 
thehive application.conf points to /opt/data for file storage but docker-compose file mounts to /data. This commit fixes the mapping.
@nadouani nadouani requested review from garanews and removed request for garanews November 19, 2020 09:10
@nadouani nadouani added this to the 4.0.2 milestone Nov 19, 2020
@nadouani
Copy link
Contributor

Thanks @KaanSK this is valid

@nadouani nadouani merged commit 1aa821a into TheHive-Project:develop-th4 Nov 19, 2020
@garanews
Copy link
Contributor

Thanks!
image

garanews
garanews reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@garanews garanews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garanews
Copy link
Contributor

@KaanSK following #1244 I fixed also right parameter, and cofirmed working:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanews garanews garanews left review comments

Assignees
No one assigned
Labels
bug docker
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@KaanSK @nadouani @garanews