Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Permit to disable similarity (case and alert) for some observable #1625

Closed
12 tasks done
To-om opened this issue Nov 6, 2020 · 0 comments
Closed
12 tasks done

[Feature Request] Permit to disable similarity (case and alert) for some observable #1625

To-om opened this issue Nov 6, 2020 · 0 comments
Assignees
@To-om
Labels
feature request TheHive4 TheHive4 related issues
Milestone
4.0.1

Comments

@To-om
Copy link
Contributor

To-om commented Nov 6, 2020 •
edited by nadouani
Loading

Request Type

Feature Request

Problem Description

Some observables should not be used for similarity. The aim of this issue is to add an attribute "ignoreSimilarity" to observables. This attribute, if true, disables similarity for that observable.

The ignoreSimilarity field is also propagated to case observables when an alert is promoted to a case. The UI needs to display this attribute and make it editable in a case:

UI changes

  • FE - Display the ignoreSimilarity flag in alert observables list
  • FE -Display the ignoreSimilarity flag in case observables list
  • FE - Display the ignoreSimilarity flag in case observable detail page
  • FE - Allow setting the attribute in the bulk update dialog
  • FE - Hide Link section from observable details page if ignoreSimilarity is set to true
  • FE - Filter observable lists using ignoreSimilarity flag
  • FE - Add ignoreSimilarity option in observable creation dialog

API changes

  • BE - Add ignoreSimilary to the /api/describe v0 APIs (Search and dashboards)
  • BE - Add ignoreSimilary to the /api/describe v1 APIs
  • BE - Rely on ignoreSimilary for related cases
  • BE - Take ignoreSimilary into account in observable PATCH API
  • BE - Take ignoreSimilary into account in observable bulk PATCH API
@To-om To-om added feature request TheHive4 TheHive4 related issues labels Nov 6, 2020
@To-om To-om added this to the 4.0.1 milestone Nov 6, 2020
@To-om To-om self-assigned this Nov 6, 2020
To-om added a commit that referenced this issue Nov 6, 2020
@To-om
#1625 Add "ignoreSimilarity" attribute in observable
4c57fec
@To-om To-om assigned nadouani and unassigned To-om Nov 6, 2020
nadouani added a commit that referenced this issue Nov 7, 2020
@nadouani
#1625 Display ignoreSimilarity in case and alert observables list
5c3a9f1
nadouani added a commit that referenced this issue Nov 7, 2020
@nadouani
#1625 Add the ignoreSimilarity flag to the observable bulk update dialog
78f1522
nadouani added a commit that referenced this issue Nov 8, 2020
@nadouani
#1625 Make ignoreSimilarity updatable via bulk patch API
ae5b910
nadouani added a commit that referenced this issue Nov 8, 2020
@nadouani
#1625 Add ignoreSimilarity to descrive v1 API
7112ed1
nadouani added a commit that referenced this issue Nov 8, 2020
@nadouani
#1625 Use observable ignoreSimilarity flag in observable details page
5230926
nadouani added a commit that referenced this issue Nov 8, 2020
@nadouani
#1625 Filter observable list using ignoreSimilarity icon clicks
1dc0a4f
@nadouani nadouani removed their assignment Nov 8, 2020
nadouani added a commit that referenced this issue Nov 8, 2020
@nadouani
#1625 Redesign the observable flag info in the list view
5ea53a9
nadouani added a commit that referenced this issue Nov 8, 2020
@nadouani
#1625 Update the observable-label component to allo inline display
cfb9009
To-om added a commit that referenced this issue Nov 9, 2020
@To-om
#1625 Fix case link with ignoreSimilarity
8d5e145
nadouani added a commit that referenced this issue Nov 9, 2020
@nadouani
#1625 Display the ignoreSimilarity icon even for observable without t…
92fec30 
…hat flag defined
nadouani added a commit that referenced this issue Nov 9, 2020
@nadouani
#1625 Use observable-flags component in case links table
67f5ac7
nadouani added a commit that referenced this issue Nov 9, 2020
@nadouani
#1625 Add ignoreSimilarity to observable creation dialog
db7f789
@nadouani nadouani closed this as completed Nov 9, 2020
nadouani added a commit that referenced this issue Nov 10, 2020
@nadouani
#1625 Fix typo
d327736
nadouani added a commit that referenced this issue Nov 12, 2020
@nadouani
#1625 Use observable flags component in observables list
3b27fe6
To-om added a commit that referenced this issue Nov 13, 2020
@To-om
#1625 Add "ignoreSimilarity" attribute in observable
4ac6b22
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Display ignoreSimilarity in case and alert observables list
2f01e60
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Add the ignoreSimilarity flag to the observable bulk update dialog
e3de16f
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Make ignoreSimilarity updatable via bulk patch API
fd16aaa
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Add ignoreSimilarity to descrive v1 API
7125db1
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Use observable ignoreSimilarity flag in observable details page
2f9fc62
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Filter observable list using ignoreSimilarity icon clicks
745e6c9
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Redesign the observable flag info in the list view
b3c9f7c
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Update the observable-label component to allo inline display
e098b5d
To-om added a commit that referenced this issue Nov 13, 2020
@To-om
#1625 Fix case link with ignoreSimilarity
ee5112d
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Display the ignoreSimilarity icon even for observable without t…
7d091f0 
…hat flag defined
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Use observable-flags component in case links table
4943e06
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Add ignoreSimilarity to observable creation dialog
a7ec187
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Fix typo
3fe80ee
To-om pushed a commit that referenced this issue Nov 13, 2020
@nadouani @To-om
#1625 Use observable flags component in observables list
8aed6e1
To-om added a commit that referenced this issue Nov 20, 2020
@To-om
#1625 Fix similarity when several observables match
1b57282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@To-om To-om

Labels
feature request TheHive4 TheHive4 related issues
Projects
None yet
Milestone
4.0.1
Development

No branches or pull requests
2 participants
@nadouani @To-om