Skip to content

Commit

Permalink
Fixed Bug #1697920: Can't assign a field type/domain of a different s…
Browse files Browse the repository at this point in the history
…chema

We now show all domains that are available in the database, pg_type_is_visible just finds out if the current type is in the search_path.  We just schema qualify all of the types and everything works.
  • Loading branch information
mr-russ committed Apr 18, 2007
1 parent 97af089 commit e5f9d9d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions HISTORY
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Features
* You can configure reports db, schema and table names

Bugs
* Fix inability to assign a field type/domain of a different schema
* Can't edit a report and set its comment to empty
* Fix PHP5 Strict mode complaints
* Fix IN/NOT IN to accept text input lists 'a','b'
Expand Down
4 changes: 2 additions & 2 deletions classes/database/Postgres73.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* A class that implements the DB interface for Postgres
* Note: This class uses ADODB and returns RecordSets.
*
* $Id: Postgres73.php,v 1.161 2007/01/10 02:01:17 soranzo Exp $
* $Id: Postgres73.php,v 1.162 2007/04/18 15:47:51 mr-russ Exp $
*/

// @@@ THOUGHT: What about inherits? ie. use of ONLY???
Expand Down Expand Up @@ -1015,7 +1015,7 @@ function createFunction($funcname, $args, $returns, $definition, $language, $fla
*/
function getTypes($all = false, $tabletypes = false, $domains = false) {
if ($all)
$where = 'pg_catalog.pg_type_is_visible(t.oid)';
$where = '1 = 1';
else
$where = "n.nspname = '{$this->_schema}'";
// Never show system table types
Expand Down

0 comments on commit e5f9d9d

Please sign in to comment.