Skip to content

Added void typo #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/Commands/EventsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

class EventsTest extends TestCase
{
public function testSuccess()
public function testSuccess(): void
{
$this->copyFiles();

Expand All @@ -29,7 +29,7 @@ public function testSuccess()
Event::assertNotDispatched(DeployOperationFailed::class);
}

public function testFailed()
public function testFailed(): void
{
$this->expectException(Exception::class);
$this->expectExceptionMessage('Custom exception');
Expand Down
16 changes: 8 additions & 8 deletions tests/Commands/MakeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

class MakeTest extends TestCase
{
public function testMakingFiles()
public function testMakingFiles(): void
{
$name = 'MakeExample';

Expand All @@ -28,7 +28,7 @@ public function testMakingFiles()
);
}

public function testAskedName()
public function testAskedName(): void
{
$path = $this->getOperationsPath() . '/' . date('Y_m_d_His') . '_some_name.php';

Expand All @@ -41,7 +41,7 @@ public function testAskedName()
$this->assertFileExists($path);
}

public function testAutoName()
public function testAutoName(): void
{
$path = $this->getOperationsPath() . '/' . date('Y_m_d_His') . '_auto.php';

Expand All @@ -54,7 +54,7 @@ public function testAutoName()
$this->assertFileExists($path);
}

public function testNestedRightSlashWithoutExtension()
public function testNestedRightSlashWithoutExtension(): void
{
$name = 'Foo/bar/QweRty';

Expand All @@ -72,7 +72,7 @@ public function testNestedRightSlashWithoutExtension()
);
}

public function testNestedRightSlashWithExtension()
public function testNestedRightSlashWithExtension(): void
{
$name = 'Foo/bar/QweRty.php';

Expand All @@ -90,7 +90,7 @@ public function testNestedRightSlashWithExtension()
);
}

public function testNestedLeftSlashWithoutExtension()
public function testNestedLeftSlashWithoutExtension(): void
{
$name = 'Foo\\bar\\QweRty';

Expand All @@ -108,7 +108,7 @@ public function testNestedLeftSlashWithoutExtension()
);
}

public function testNestedLeftSlashWithExtension()
public function testNestedLeftSlashWithExtension(): void
{
$name = 'Foo\\bar\\QweRty.php';

Expand All @@ -126,7 +126,7 @@ public function testNestedLeftSlashWithExtension()
);
}

public function testFromCustomizedStub()
public function testFromCustomizedStub(): void
{
$name = 'MakeExample';

Expand Down
8 changes: 4 additions & 4 deletions tests/Commands/MutexTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public function handle(): int
$this->command->setLaravel($container);
}

public function testCanRunIsolatedCommandIfNotBlocked()
public function testCanRunIsolatedCommandIfNotBlocked(): void
{
$this->mutex->shouldReceive('create')
->andReturn(true)
Expand All @@ -53,7 +53,7 @@ public function testCanRunIsolatedCommandIfNotBlocked()
$this->assertSame(1, $this->command->ran);
}

public function testCannotRunIsolatedCommandIfBlocked()
public function testCannotRunIsolatedCommandIfBlocked(): void
{
$this->mutex->shouldReceive('create')
->andReturn(false)
Expand All @@ -67,7 +67,7 @@ public function testCannotRunIsolatedCommandIfBlocked()
$this->assertSame(0, $this->command->ran);
}

public function testCanRunCommandAgainAfterOtherCommandFinished()
public function testCanRunCommandAgainAfterOtherCommandFinished(): void
{
$this->mutex->shouldReceive('create')
->andReturn(true)
Expand All @@ -82,7 +82,7 @@ public function testCanRunCommandAgainAfterOtherCommandFinished()
$this->assertEquals(2, $this->command->ran);
}

public function testCanRunCommandAgainNonAutomated()
public function testCanRunCommandAgainNonAutomated(): void
{
$this->mutex->shouldNotHaveBeenCalled();

Expand Down
50 changes: 25 additions & 25 deletions tests/Commands/OperationsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

class OperationsTest extends TestCase
{
public function testSuccess()
public function testSuccess(): void
{
$this->assertDatabaseDoesntTable($this->table);

Expand All @@ -32,7 +32,7 @@ public function testSuccess()
$this->assertDatabaseOperationHas($this->table, 'test_migration');
}

public function testSameName()
public function testSameName(): void
{
$this->assertDatabaseDoesntTable($this->table);

Expand All @@ -52,7 +52,7 @@ public function testSameName()
$this->assertDatabaseOperationHas($this->table, 'test_migration');
}

public function testOnce()
public function testOnce(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -85,7 +85,7 @@ public function testOnce()
$this->assertDatabaseOperationDoesntLike($this->table, $table);
}

public function testSuccessTransaction()
public function testSuccessTransaction(): void
{
$this->copySuccessTransaction();

Expand All @@ -103,7 +103,7 @@ public function testSuccessTransaction()
$this->assertDatabaseOperationHas($this->table, $table);
}

public function testFailedTransaction()
public function testFailedTransaction(): void
{
$this->copyFailedTransaction();

Expand All @@ -128,7 +128,7 @@ public function testFailedTransaction()
$this->assertDatabaseOperationDoesntLike($this->table, $table);
}

public function testSingleEnvironment()
public function testSingleEnvironment(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -163,7 +163,7 @@ public function testSingleEnvironment()
$this->assertDatabaseOperationDoesntLike($this->table, 'run_except_testing');
}

public function testManyEnvironments()
public function testManyEnvironments(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -204,7 +204,7 @@ public function testManyEnvironments()
$this->assertDatabaseOperationDoesntLike($this->table, 'run_except_many_environments');
}

public function testAllow()
public function testAllow(): void
{
$this->copyFiles();

Expand All @@ -230,7 +230,7 @@ public function testAllow()
$this->assertDatabaseOperationDoesntLike($this->table, 'run_disallow');
}

public function testUpSuccess()
public function testUpSuccess(): void
{
$this->copyFiles();

Expand All @@ -248,7 +248,7 @@ public function testUpSuccess()
$this->assertDatabaseOperationHas($this->table, 'run_success');
}

public function testUpSuccessOnFailed()
public function testUpSuccessOnFailed(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -283,7 +283,7 @@ public function testUpSuccessOnFailed()
$this->assertDatabaseOperationDoesntLike($this->table, 'run_success_on_failed');
}

public function testUpFailed()
public function testUpFailed(): void
{
$this->copyFiles();

Expand All @@ -301,7 +301,7 @@ public function testUpFailed()
$this->assertDatabaseOperationHas($this->table, 'run_failed');
}

public function testUpFailedOnException()
public function testUpFailedOnException(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -336,7 +336,7 @@ public function testUpFailedOnException()
$this->assertDatabaseOperationDoesntLike($this->table, 'run_failed_failure');
}

public function testPathAsFileWithExtension()
public function testPathAsFileWithExtension(): void
{
$this->copyFiles();

Expand All @@ -358,7 +358,7 @@ public function testPathAsFileWithExtension()
$this->assertSame('sub_path/2021_12_15_205804_baz', $this->table()->first()->operation);
}

public function testPathAsFileWithoutExtension()
public function testPathAsFileWithoutExtension(): void
{
$this->copyFiles();

Expand All @@ -380,7 +380,7 @@ public function testPathAsFileWithoutExtension()
$this->assertSame($path, $this->table()->first()->operation);
}

public function testPathAsDirectory()
public function testPathAsDirectory(): void
{
$this->copyFiles();

Expand All @@ -402,7 +402,7 @@ public function testPathAsDirectory()
$this->assertSame('sub_path/2021_12_15_205804_baz', $this->table()->first()->operation);
}

public function testOperationsNotFound()
public function testOperationsNotFound(): void
{
$this->assertDatabaseDoesntTable($this->table);

Expand All @@ -413,7 +413,7 @@ public function testOperationsNotFound()
$this->artisan(Names::Status)->assertExitCode(0);
}

public function testDisabledBefore()
public function testDisabledBefore(): void
{
$this->copyFiles();

Expand All @@ -439,7 +439,7 @@ public function testDisabledBefore()
$this->assertDatabaseOperationHas($this->table, 'test_before_disabled');
}

public function testEnabledBefore()
public function testEnabledBefore(): void
{
$this->copyFiles();

Expand All @@ -465,7 +465,7 @@ public function testEnabledBefore()
$this->assertDatabaseOperationDoesntLike($this->table, 'test_before_disabled');
}

public function testMixedBefore()
public function testMixedBefore(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -563,7 +563,7 @@ public function testSorting(): void
$this->assertSame($files, $records);
}

public function testDirectoryExclusion()
public function testDirectoryExclusion(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -613,7 +613,7 @@ public function testDirectoryExclusion()
$this->assertDatabaseOperationDoesntLike($this->table, 'sub_path/2022_10_27_230732_foo');
}

public function testFileExclusion()
public function testFileExclusion(): void
{
$this->copyFiles();

Expand Down Expand Up @@ -658,7 +658,7 @@ public function testFileExclusion()
$this->assertDatabaseOperationHas($this->table, 'sub_path/2022_10_27_230732_foo');
}

public function testEmptyDirectory()
public function testEmptyDirectory(): void
{
$this->copyEmptyDirectory();

Expand All @@ -675,7 +675,7 @@ public function testEmptyDirectory()
$this->assertDatabaseCount($this->table, 0);
}

public function testAsync()
public function testAsync(): void
{
$this->copyAsync();

Expand Down Expand Up @@ -711,7 +711,7 @@ public function testAsync()
]));
}

public function testSync()
public function testSync(): void
{
$this->copyAsync();

Expand Down Expand Up @@ -748,7 +748,7 @@ public function testSync()
$this->assertDatabaseOperationDoesntLike($this->table, 'every_time');
}

public function testViaMigrationMethod()
public function testViaMigrationMethod(): void
{
$this->copyViaMigrations();

Expand Down
2 changes: 1 addition & 1 deletion tests/Commands/RefreshTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class RefreshTest extends TestCase
{
public function testRefreshCommand()
public function testRefreshCommand(): void
{
$this->assertDatabaseDoesntTable($this->table);

Expand Down
2 changes: 1 addition & 1 deletion tests/Commands/ResetTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class ResetTest extends TestCase
{
public function testResetCommand()
public function testResetCommand(): void
{
$this->assertDatabaseDoesntTable($this->table);

Expand Down
Loading
Loading