Skip to content

Fix dependency injection to support lumen #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

Kuodster
Copy link
Contributor

Hello.

The current application dependency for the Migrator class is using a non-existent class in Lumen framework.

DragonCode\LaravelActions\Services\Migrator::__construct(): Argument #5 ($laravel) must be of type Illuminate\Contracts\Foundation\Application, Laravel\Lumen\Application given

Lumen and Laravel applications both implement Illuminate\Contracts\Container\Container interface, which is the one used to provide the call() method used by the package.

@Kuodster Kuodster marked this pull request as ready for review January 25, 2024 15:03
@andrey-helldar andrey-helldar merged commit 5c52f37 into TheDragonCode:main Jan 25, 2024
@andrey-helldar
Copy link
Member

Thank you!

@andrey-helldar andrey-helldar added the minor Non-critical changes to the project structure label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non-critical changes to the project structure
Development

Successfully merging this pull request may close these issues.

2 participants