Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please increase versionCode #47

Closed
IzzySoft opened this issue Nov 16, 2020 · 12 comments · Fixed by #241
Closed

please increase versionCode #47

IzzySoft opened this issue Nov 16, 2020 · 12 comments · Fixed by #241
Labels
enhancement New feature or request

Comments

@IzzySoft
Copy link

could you please increase versionCode when making a new release? That's what Android tells the versions apart by – so as today's release still has versionCode: 1 Android won't consider it as an update for those having the previous version installed. Thanks!

@Spikeysanju
Copy link
Member

@IzzySoft Sure man! Thanks for the info

@Spikeysanju Spikeysanju added the enhancement New feature or request label Nov 17, 2020
@IzzySoft
Copy link
Author

IzzySoft commented Apr 8, 2021

Gladly given! Now your 3rd release was made, and versionCode is still set to 1. Maybe leave the issue open so you don't forget? 🤣

@Spikeysanju
Copy link
Member

Haha Sorry my bad 🤣 . Every time I forgot to update the version code. Thanks for the reminder 👍

@Spikeysanju Spikeysanju reopened this Apr 9, 2021
Spikeysanju added a commit that referenced this issue Apr 9, 2021
Signed-off-by: Sanju S <spikeysanju98@gmail.com>
@Spikeysanju
Copy link
Member

Spikeysanju commented Apr 9, 2021

@IzzySoft It was fixed in the latest commit buddy ✅ . Thanks for the reminder. Have a great day!

@IzzySoft
Copy link
Author

IzzySoft commented Apr 9, 2021

🤣 Please reopen again, you once more forgot versionCode – it's still set to 1 but should be, err, 4 meanwhile?

    defaultConfig {
        applicationId "thecodemonks.org.nottzapp"
        minSdkVersion 21
        targetSdkVersion 30
        versionCode 1
        versionName "1.3.3"

Remember:

  • versionName: what's displayed to the user (and most likely will be used when reporting issues)
  • versionCode: what Android uses internally to tell versions apart; this is the most important one to always increase with each new release

@IzzySoft
Copy link
Author

@Spikeysanju my updater still gives me daily alerts because of the versionCode, so I'm disabling the update check for now. Please drop me a note once you fixed it, @Spikeysanju – thanks!

@IzzySoft
Copy link
Author

@Spikeysanju any chance? Btw it's irritating that the APK at release tag v1.3 still identifies as 0.1.3 😉

@IzzySoft
Copy link
Author

IzzySoft commented Nov 8, 2021

@Spikeysanju again you forgot: my updater just fetched a new version last night (we're at 1.4 now), and it still shows versionCode: 1. None of your users will ever receive update notifications, or be otherwise aware of new versions: even if they look at their F-Droid app, it will seem to them that they have the latest version already installed – as Android thinks so.

Maybe one year after reporting, can we get this finally fixed, please? Thanks!

@Spikeysanju Spikeysanju linked a pull request Nov 8, 2021 that will close this issue
@Spikeysanju
Copy link
Member

@IzzySoft Oops I'm sorry I forgot to update the version everytime 😬.

I've updated the version code to 4. Please check it out. Thanks for bringing this up 🙌

Checkout the latest 👇
release

Checkout latest pr 👇
#241

@IzzySoft
Copy link
Author

IzzySoft commented Nov 8, 2021

Thanks! That one looks good. Just downloaded it manually (as my updater was now fooled by the fact it already had processed that tag) and checked. Will become visible in about 1.5h from now (with the next sync).

Will it now work well for the next releases, too? 😃

@Spikeysanju
Copy link
Member

Yeah sure, I hope I will remember this for sure next time 😄. Have a great day buddy!

@IzzySoft
Copy link
Author

You too, friend! And should you forget again, I'll come and remind you 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants