Update TypeScript configs and add changeset for minor version release #29
Conversation
🦋 Changeset detectedLatest commit: 0e3bf00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThe changes update TypeScript configuration files for a project. The base configuration removes the "rootDir" option, while the library configuration adds it. The Next.js configuration receives new compiler options for library targets and module resolution. A changeset file is added to document a minor version update for the package. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant tsconfig.base.json
participant tsconfig.lib.json
participant tsconfig.next.json
Developer->>tsconfig.base.json: Loads configuration (without rootDir)
Developer->>tsconfig.lib.json: Loads configuration (with rootDir)
Developer->>tsconfig.next.json: Loads configuration (with new lib, module, moduleResolution)
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
coderabbitai
bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/long-kings-ask.md (1)
5-5: Use official "Next.js" spelling in description
The description uses “NextJS” but the framework’s official name is “Next.js”. Updating this improves consistency and avoids typos.-Fix NextJS TSConfig +Fix Next.js TSConfig🧰 Tools
🪛 LanguageTool
[uncategorized] ~5-~5: The official spelling of this programming framework is “Next.js”.
Context: ... '@tcd-devkit/tsconfig': minor --- Fix NextJS TSConfig(NODE_JS)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.changeset/long-kings-ask.md(1 hunks)packages/tsconfig/tsconfig.base.json(0 hunks)packages/tsconfig/tsconfig.lib.json(1 hunks)packages/tsconfig/tsconfig.next.json(1 hunks)
💤 Files with no reviewable changes (1)
- packages/tsconfig/tsconfig.base.json
🧰 Additional context used
🪛 LanguageTool
.changeset/long-kings-ask.md
[uncategorized] ~5-~5: The official spelling of this programming framework is “Next.js”.
Context: ... '@tcd-devkit/tsconfig': minor --- Fix NextJS TSConfig
(NODE_JS)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: main
🔇 Additional comments (3)
.changeset/long-kings-ask.md (1)
1-3: Validate version bump in changeset header
The changeset correctly specifies a minor bump for@tcd-devkit/tsconfig. Ensure that this aligns with the semantic changes introduced (non-breaking enhancements to TSConfig).packages/tsconfig/tsconfig.lib.json (1)
7-7: Approve addition of rootDir for library config
MovingrootDirto the library-specific config ensures that input files are correctly scoped to the config directory. This complements its removal from the base config.packages/tsconfig/tsconfig.next.json (1)
5-7:✅ Verification successful
Verify TypeScript version compatibility for new compiler options
The additions enable support for DOM APIs and bundler-based resolution (moduleResolution: "bundler"), which require TypeScript ≥ 5.0. Ensure the project’s TS version meets this requirement.Run the following script to check the TypeScript version in your
package.json:
🏁 Script executed:
#!/bin/bash # Description: Verify that TypeScript version meets minimum requirements for "moduleResolution: bundler" (TS >=5.0) TS_VERSION=$(jq -r '.devDependencies.typescript // .dependencies.typescript' package.json) echo "TypeScript version: $TS_VERSION"Length of output: 159
Resolved: TypeScript version compatibility confirmed
The project is using TypeScript 5.8.3, which satisfies the minimum requirement (≥ 5.0) for
"moduleResolution": "bundler"and the added DOM libs. No further action needed.
Summary by CodeRabbit