Skip to content

Conversation

@hanndoddi
Copy link

Hi all! I’m starting to get into open source and really like this project.

I noticed the README could use some formatting cleanup, so I went ahead and updated it. I hope this helps, happy to improve it further if needed. I have some more ideas but didn’t want to change too much to begin with. If you have suggestions, please feel free to share them!

All the best from Iceland! 🇮🇸

@hanndoddi
Copy link
Author

I just realized I forgot to check existing pull requests before submitting this, there's already a very similar one in PR #24.
I’ll leave this open just in case, though it may be redundant.

README.md Outdated
## 📄 License

Internet connection when using online
This project is licensed under the [MIT License](https://opensource.org/license/mit).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Licence included in the project is actually the GPL 2.0.

@barianos
Copy link

I just realized I forgot to check existing pull requests before submitting this, there's already a very similar one in PR #24. I’ll leave this open just in case, though it may be redundant.

Instead of leaving two very similar PRs open, would you be interested in merging mine into this and keeping the good parts of both? Then I could close mine.

@hanndoddi
Copy link
Author

I just realized I forgot to check existing pull requests before submitting this, there's already a very similar one in PR #24. I’ll leave this open just in case, though it may be redundant.

Instead of leaving two very similar PRs open, would you be interested in merging mine into this and keeping the good parts of both? Then I could close mine.

Great idea, I’ll go ahead and merge yours in.

I also noticed in the updated README that there’s some exciting work being done to reorient the project and take it further. Happy to collaborate with you on improving the documentation down the road if the opportunity comes up.

I’ll finish the merge now, even though the project might shift directions, just to keep a clean track record of contributions.

@barianos
Copy link

I just realized I forgot to check existing pull requests before submitting this, there's already a very similar one in PR #24. I’ll leave this open just in case, though it may be redundant.

Instead of leaving two very similar PRs open, would you be interested in merging mine into this and keeping the good parts of both? Then I could close mine.

Great idea, I’ll go ahead and merge yours in.

I also noticed in the updated README that there’s some exciting work being done to reorient the project and take it further. Happy to collaborate with you on improving the documentation down the road if the opportunity comes up.

I’ll finish the merge now, even though the project might shift directions, just to keep a clean track record of contributions.

I closed mine, so at least the PR list is a bit cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants