Skip to content

Conversation

@PurelyAndy
Copy link

@PurelyAndy PurelyAndy commented May 10, 2025

I'm rewriting the GUI with Avalonia and restructuring the projects, moving shared code, cleaning up, etc.

image

@PurelyAndy PurelyAndy marked this pull request as draft May 10, 2025 00:18
Co-Authored-By: VashBaldeus <vashbaldeus@gmail.com>
PurelyAndy and others added 2 commits May 10, 2025 14:04
@PurelyAndy PurelyAndy marked this pull request as ready for review May 12, 2025 01:08
@PurelyAndy
Copy link
Author

I don't own a PS5, so I can't test the UART communication code. If anybody is willing to help me out with that, please let me know.

@falconmick
Copy link

Don’t have an open ps5 to test on but lmk if you would like any help

@benjamin238
Copy link

Hey @PurelyAndy, I've taken a brief look at the refactored code and agree that this is the direction we should be heading in. This fork is very well organized and solves many problems the current main branch has.

I'm attempting to merge a small change I made but I don't have write access to your fork. Would you be able to provide that for me? Thanks :3

@Ayymoss
Copy link

Ayymoss commented May 12, 2025

This is good. We still need to clean up https://github.com/PurelyAndy/PS5NorModifier/blob/main/UART-CL_By_TheCod3r/Program.cs 's monolithic class

@florianknecht florianknecht mentioned this pull request May 12, 2025
@PurelyAndy
Copy link
Author

Yeah, I'm working on that right now. There's a lot of shared code between the GUI and CLI apps that needs to be consolidated.

@PurelyAndy
Copy link
Author

PurelyAndy commented May 12, 2025

@benjamin238 I'll give you access now. It's in your email.

@PurelyAndy PurelyAndy changed the title Cross-platform support & code cleanup Cross-platform support, completely refactor the project. May 12, 2025
@Ayymoss
Copy link

Ayymoss commented May 13, 2025

Why downgrade from .NET 9 to .NET 8 out of curiosity?

Could it not be compiled as Native AOT? Avalonia supports it: https://docs.avaloniaui.net/docs/deployment/native-aot

@PurelyAndy
Copy link
Author

PurelyAndy commented May 13, 2025

.NET 8 is LTS. I don't know how often they want to update the .NET version of this project. It's trivial to update it back to .NET 9 or 10 in the future, anyway.

@RJohnsonPGH
Copy link

I've also submitted a PR for a rewrite and to clean up the CLI, but I took a more drastic approach. @PurelyAndy if you want to take a look #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants